Skip to content

Security Center - Fix JIT documentation #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annatisch merged 1 commit into from
Jul 13, 2018
Merged

Security Center - Fix JIT documentation #3407

annatisch merged 1 commit into from
Jul 13, 2018

Conversation

@chlahav
Copy link
Contributor

@chlahav chlahav commented Jul 12, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci azuresdkci requested a review from annatisch July 12, 2018 10:53
@AutorestCI
Copy link

AutorestCI commented Jul 12, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@chlahav chlahav force-pushed the master branch 2 times, most recently from 7c14770 to f6c320f Compare July 12, 2018 11:24
annatisch
annatisch requested changes Jul 12, 2018
View reviewed changes
...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo correction:
"Source of the allowed traffic. If omitted, the request will be for the source IP address of the initiate request."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo correction:
"IP addess or CIDR, for example \"192.168.0.3\" or \"192.168.0.0/16\"."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo correction:
"IP address or CIDR, for example \"192.168.0.3\" or \"192.168.0.0/16\"."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo correction:
"Mutually exclusive with the \"allowedSourceAddressPrefixes\" parameter. Should be an IP address or CIDR, for example \"192.168.0.3\" or \"192.168.0.0/16\"."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo correction:
"Mutually exclusive with the \"allowedSourceAddressPrefix\" parameter."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo corrections:
"Mutually exclusive with the \"allowedSourceAddressPrefixes\" parameter. Should be an IP address or CIDR, for example \"192.168.0.3\" or \"192.168.0.0/16\"."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

...cation/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/security.json Outdated
Copy link
Member

@annatisch annatisch Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar and typo correction:
"Mutually exclusive with the \"allowedSourceAddressPrefix\" parameter."

Copy link
Contributor Author

@chlahav chlahav Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@annatisch
Copy link
Member

annatisch commented Jul 13, 2018

Thanks @chlahav!
Changes look good to me.
Just to confirm - you're aware that this PR includes breaking changes that will require a major version bump of any published SDKs?

@chlahav
Copy link
Contributor Author

chlahav commented Jul 13, 2018 •
edited
Loading

@annatisch Yes, we don't have any published SDK yet.
In fact, we found these errors while testing an SDK before publishing it 🙂

@annatisch annatisch merged commit fd89b6a into Azure:master Jul 13, 2018
@chlahav chlahav mentioned this pull request Jul 16, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch approved these changes

Assignees

@annatisch annatisch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chlahav @AutorestCI @annatisch