Azure Search: Add resource identity (MSI) support#3377
Azure Search: Add resource identity (MSI) support#3377jhendrixMSFT merged 2 commits intoAzure:masterfrom
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
|
Shouldn't this feature be in preview version? |
|
This feature doesn't need to be in a preview version as it is backward compatible due to the following:
|
|
Thanks, Nati. LGTM |
| "enum": [ | ||
| "SystemAssigned" | ||
| ], | ||
| "x-ms-enum": { |
There was a problem hiding this comment.
as discussed, let's see if we really need this
| "principalId": { | ||
| "readOnly": true, | ||
| "type": "string", | ||
| "description": "The principal ID of resource identity." |
There was a problem hiding this comment.
The principal ID of the resource identity.
| "tenantId": { | ||
| "readOnly": true, | ||
| "type": "string", | ||
| "description": "The tenant ID of resource." |
There was a problem hiding this comment.
The tenant ID of the resource.
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "description": "The identity type.", |
There was a problem hiding this comment.
Is there more detail we can add here so the generated documentation will be more self-explanatory?
6 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger