[Datafactory] Add Tumbling Window dependsOn property to Trigger.json for Tumbling Window Trigger and self-dependent Tumbling Window Trigger by alexsaff · Pull Request #3356 · Azure/azure-rest-api-specs

alexsaff · 2018-07-05T18:15:15Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…erence

…dent version

AutorestCI · 2018-07-05T18:16:36Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-07-05T19:05:51Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-07-05T19:18:36Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-07-05T19:22:58Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2136

hovsepm · 2018-07-05T20:08:29Z

@alexsaff please ping me directly when this PR will be ready for review and merge.

AutorestCI · 2018-07-05T20:20:58Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2222

hvermis · 2018-07-06T05:49:31Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+          "description": "Referenced trigger",
+          "$ref": "#/definitions/TriggerReference"
+        },
+        "offset": {


offset and size can be moved to a separate type and reused in both self dependency and tumbling widow dependency reference classes. Please refer to the mail thread and the doc Nailini created. #Resolved

Also it will be better to create another class derived from DependencyReference as Nalini had in her doc and put referenceTrigger in that class, because in future if you support ScheduledTriggerReference, it will be derived from this new class along with TumblingWindowTriggerDependencyReference. Only in case of self rereference you don't need to have referenceTrigger property, in all other cases you will need it. If we don't do these changes now, later they will breaking changes. #Resolved

Offset is required for self-dependency, so it makes not much sense to create a separate type for offset and size. #Resolved

TriggerDependencyReference has been added #Resolved

hvermis · 2018-07-07T01:23:22Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+            },
+            "dependsOn": {
+              "type": "array",
+              "description": "Tumbling window triggers that this trigger depends on. Only tumbling window triggers are supported.",


Tumbling window [](start = 30, length = 16)

Remove this tumbling window part from here:
Triggers that this trigger depends on. Only tumbling window triggers are supported. #Resolved

hvermis · 2018-07-07T01:24:13Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      ]
+    },
+    "DependencyReference": {
+      "description": "Referenced dependency",


Need dot at the end, otherwise validation will fail. #Resolved

hvermis · 2018-07-07T01:24:26Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      "discriminator": "type",
+      "properties": {
+        "type": {
+          "description": "The type of dependency reference",


Dot #Resolved

hvermis · 2018-07-07T01:24:33Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      ]
+    },
+    "TriggerDependencyReference": {
+      "description": "Trigger referenced dependency",


Dot #Resolved

hvermis · 2018-07-07T01:25:04Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      ],
+      "properties": {
+        "referenceTrigger": {
+          "description": "Referenced trigger",


Dot #Resolved

hvermis · 2018-07-07T01:25:15Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      ]
+    },
+    "TumblingWindowTriggerDependencyReference": {
+      "description": "Referenced tumbling window trigger dependency",


Dot #Resolved

hvermis · 2018-07-07T01:28:33Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      ],
+      "properties": {
+        "offset": {
+          "description": "Timespan applied to the start time of a tumbling window when evaluating dependency, pattern: ((\\d+)\\.)?(\\d\\d):(60|([0-5][0-9])):(60|([0-5][0-9])).",


((\d+)\.)?(\d\d):(60|([0-5][0-9])):(60|([0-5][0-9])) [](start = 119, length = 56)

I think you can add this as validation, then SDK will have a code for that. Check the parameters section in https://github.com/Azure/azure-rest-api-specs/blob/master/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

hvermis · 2018-07-07T01:28:46Z

...y/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/Trigger.json

+      }
+    },
+    "SelfDependencyTumblingWindowTriggerReference": {
+      "description": "Self referenced tumbling window trigger dependency",


Dot #Resolved

hvermis

jhendrixMSFT · 2018-07-11T23:18:52Z

@AutorestCI regenerate azure-sdk-for-go

alexsaff · 2018-07-13T20:09:44Z

Replace by #3414

alexsaff added 6 commits April 18, 2018 14:55

Add Tumbling Window dependsOn property

d3332a5

Updates on hvermis notes

b67ca87

Fix build error due to #ref change

9001692

Update enum for TumblingWindowTriggerReference to TriggerReference

c304005

Update to use TriggerReference instead of Tumbling window trigger ref…

d5f7d2b

…erence

Refactor DependsOn for regular Tumbling Window Trigger ans self-depen…

b004701

…dent version

azuresdkci assigned hovsepm Jul 5, 2018

azuresdkci requested a review from hovsepm July 5, 2018 18:15

alexsaff changed the title ~~Master~~ [Do not merge][Datafactory] Add Tumbling Window dependsOn property to Trigger.json for Tumbling Window Trigger and self-dependent Tumbling Window Trigger Jul 5, 2018

AutorestCI mentioned this pull request Jul 5, 2018

[AutoPR datafactory/resource-manager] [Do not merge][Datafactory] Add Tumbling Window dependsOn property to Trigger.json for Tumbling Window Trigger and self-dependent Tumbling Window Trigger Azure/azure-sdk-for-java#2183

Closed

hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 5, 2018

AutorestCI mentioned this pull request Jul 5, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Tumbling Window dependsOn property to Trigger.json for Tumbling Window Trigger and self-dependent Tumbling Window Trigger Azure/azure-sdk-for-go#2188

Closed

Update description for TriggerReference

a2ed130

hvermis requested changes Jul 6, 2018

View reviewed changes

alexsaff added 2 commits July 6, 2018 07:09

Added TriggerDependencyReference

b5ab037

Fix syntax

1e8254b

hvermis reviewed Jul 7, 2018

View reviewed changes

hvermis approved these changes Jul 7, 2018

View reviewed changes

alexsaff added 2 commits July 9, 2018 10:23

Add dots to descriptions

b8ba26d

Add validation for size and offset

5859a04

AutorestCI mentioned this pull request Jul 11, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Tumbling Window dependsOn property to Trigger.json for Tumbling Window Trigger and self-dependent Tumbling Window Trigger Azure/azure-sdk-for-go#2222

Closed

haoyingli mentioned this pull request Jul 13, 2018

[Datafactory]Add Tumbling Window dependsOn property to Trigger.json for Tumbling W… #3414

Closed

10 tasks

alexsaff closed this Jul 13, 2018

Conversation

alexsaff commented Jul 5, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

hovsepm commented Jul 5, 2018

Uh oh!

AutorestCI commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

hvermis Jul 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexsaff Jul 6, 2018 • edited by hvermis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexsaff Jul 6, 2018 • edited by hvermis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018

Choose a reason for hiding this comment

Uh oh!

hvermis Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis left a comment

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Jul 11, 2018

Uh oh!

alexsaff commented Jul 5, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 5, 2018 •

edited

Loading

AutorestCI commented Jul 5, 2018 •

edited

Loading

AutorestCI commented Jul 5, 2018 •

edited

Loading

AutorestCI commented Jul 5, 2018 •

edited

Loading

AutorestCI commented Jul 5, 2018 •

edited

Loading

hvermis Jul 6, 2018 •

edited

Loading

hvermis Jul 6, 2018 •

edited

Loading

alexsaff Jul 6, 2018 •

edited by hvermis

Loading

alexsaff Jul 6, 2018 •

edited by hvermis

Loading

hvermis Jul 7, 2018 •

edited

Loading

hvermis Jul 7, 2018 •

edited

Loading

hvermis Jul 7, 2018 •

edited

Loading

hvermis Jul 7, 2018 •

edited

Loading

hvermis Jul 7, 2018 •

edited

Loading

hvermis Jul 7, 2018 •

edited

Loading

hvermis Jul 7, 2018 •

edited

Loading