Skip to content

[SCVMM] Adding a new API version (2025-03-13).#33391

Merged
kartikverma020 merged 9 commits intoAzure:mainfrom
kartikverma020:vermakartik/2025-03-13
Apr 4, 2025
Merged

[SCVMM] Adding a new API version (2025-03-13).#33391
kartikverma020 merged 9 commits intoAzure:mainfrom
kartikverma020:vermakartik/2025-03-13

Conversation

@kartikverma020
Copy link
Contributor

@kartikverma020 kartikverma020 commented Mar 21, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 21, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 21, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 21, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ScVmm
Microsoft.ScVmm

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 21, 2025
@kartikverma020 kartikverma020 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Mar 21, 2025
@kartikverma020 kartikverma020 changed the title Base commit. Adding a copy of the existing api version. [SCVMM] Adding a new API version (2025-03-13). Mar 21, 2025
@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 21, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 21, 2025
@tadelesh
Copy link
Member

go breaking change introduced in this pr: #30401.

@kartikverma020 kartikverma020 merged commit d6654fc into Azure:main Apr 4, 2025
28 of 30 checks passed
v-maksymm pushed a commit that referenced this pull request Apr 8, 2025
* Base commit. Adding a copy of the existing api version.

* Update readme.md

* Updating main.tsp with the new api version and models.tsp with the new properties.

* Updating scvmm.json

* Updating the examples.

* append suppression

---------

Co-authored-by: Judy Liu <v-liujudy@microsoft.com>
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
* Base commit. Adding a copy of the existing api version.

* Update readme.md

* Updating main.tsp with the new api version and models.tsp with the new properties.

* Updating scvmm.json

* Updating the examples.

* append suppression

---------

Co-authored-by: Judy Liu <v-liujudy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-Python-Sdk-Approved new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants