Merged
Conversation
…into needuv/unified-ai-data-plane-tsp
* removed some fields from ResourceBase * dataset contract fixes * cleanup * added start pending upload --------- Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
* Remove `-1dp` from swagger file name. Update route for get connecitons with credentials * Remove doc string comment `[Required]` * Fix swagger name in data-plane readme.md
Co-authored-by: Neehar Duvvuri <neeharduvvuri@Neehars-MacBook-Pro.local>
johanste
reviewed
May 1, 2025
* Fixing review comments * Evaluation Review Commnets fixed * Reverting non required change
* Add evaluation Id * Update JSON
* clean-up contract details * update json/compile * scan name optional * remove stable changes
* add content type header for patch * pull from base --------- Co-authored-by: Neehar Duvvuri <neeharduvvuri@Neehars-MacBook-Pro.local>
* Remove List Query Params, Remove Body from Dataset Get Credentials * clean up unused imports * fix examples for swagger validation * fix samples * add missing evaluatorId * apparently evaluator/evaluator id both exist n the same payload --------- Co-authored-by: Neehar Duvvuri <neeharduvvuri@Neehars-MacBook-Pro.local>
* Add FieldMapping to index * update doc string --------- Co-authored-by: Neehar Duvvuri <neeharduvvuri@Neehars-MacBook-Pro.local>
YusakuNo1
approved these changes
May 7, 2025
Contributor
YusakuNo1
left a comment
YusakuNo1
left a comment
There was a problem hiding this comment.
Evaluation related API looks good. As it's preview API, some fields may change in GA
YusakuNo1
approved these changes
May 7, 2025
Contributor
YusakuNo1
left a comment
YusakuNo1
left a comment
There was a problem hiding this comment.
Evaluation related API looks good. As it's preview API, some fields may change in GA
posaninagendra
approved these changes
May 7, 2025
adyada
approved these changes
May 7, 2025
andscho-msft
approved these changes
May 7, 2025
code-vicar
approved these changes
May 8, 2025
johanste
reviewed
May 8, 2025
johanste
reviewed
May 8, 2025
* Fix TypeSpec Validation * fix examples * fix swagger examples * clean up imports and delete a client file * clean up more unused imports" * fix examples --------- Co-authored-by: Neehar Duvvuri <neeharduvvuri@Neehars-MacBook-Pro.local>
johanste
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.
fix #33630