-
Notifications
You must be signed in to change notification settings - Fork 5.6k
SRP Jan25 [2025-01-01] API Version Swagger Updates #33106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please indicate what's the rest API change for the new API version, besides the API version change.
- Please split the PR to commits: 1. Copy latest API version without any change to new API version folder with 1 commit, 2. only change the API version in the new API version folder with 1 commit, 3. Add the new rest API change with several commits
- Please don't merge the PR before this API version is generally available in all regions, or we will get customer issue. We have get customer issue that 2024-01-01 is not available on chinanorth3 (but swagger PR merged), and still not mitigated.
Besides that, if the PR won't be ready to be merged to public swagger repo in short time, please don't raise PR to public repo. Instead raise PR to private repo https://github.com/Azure/azure-rest-api-specs-pr, if you only want the rest API change be reviewed.
Hi,
|
| "StorageAccounts" | ||
| ], | ||
| "operationId": "StorageAccounts_Failover", | ||
| "description": "A failover request can be triggered for a storage account in the event a primary endpoint becomes unavailable for any reason. The failover occurs from the storage account's primary cluster to the secondary cluster for RA-GRS accounts. The secondary cluster will become primary after failover and the account is converted to LRS. In the case of a Planned Failover, the primary and secondary clusters are swapped after failover and the account remains geo-replicated. Failover should continue to be used in the event of availability issues as Planned failover is only available while the primary and secondary endpoints are available. The primary use case of a Planned Failover is disaster recovery testing drills. This type of failover is invoked by setting FailoverType parameter to 'Planned'. Learn more about the failover options here- https://learn.microsoft.com/azure/storage/common/storage-disaster-recovery-guidance", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"en-us" in the doc link should be removed.
It looks this PR is not based on the latest swagger in public repo.
| ], | ||
| "description": "Settings for Azure Files identity based authentication." | ||
| }, | ||
| "SmbOAuthSettings": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need PSH/CLI support?
If so , please mail to me, and share the PM contact, release type, release schedule, feature/rest API spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need Powershell/CLI support to update property.
Priyanka Gangal is our PM.
Release type is 1P by Sept2025. 3P support will come only after that (dates not finalized until 1P ships).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mail to me, and include feature PM (and other contact if necessary) in the mail.
What do you mean by "1P" and "3P"?
And please organize the commit in this PR per my comments #33106 (comment)
for #2, please split this PR per requirements. Don;t merge the API version change together with the real API change to same commit. This is to help review of the real API change. For #3, If the change is not ready to be public, the PR should not be file on the public repo. For only review purpose, please file the PR to private repo: https://github.com/Azure/azure-rest-api-specs-pr. |


Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.