Review request for Microsoft.DBforPostgreSQL to add version preview/2025-01-01-preview by nasc17 · Pull Request #33028 · Azure/azure-rest-api-specs

nasc17 · 2025-03-05T21:47:06Z

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[C ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

Autonomous Tuning Support
Updates to Tuning Options properties
Add missing server states [BUG] Postgresql flexible server missing state of "Restarting" #33753

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2025-03-05T21:47:10Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-03-05T21:47:11Z

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

azure-sdk · 2025-03-05T21:49:59Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Swagger	Microsoft.DBforPostgreSQL

JiaqiZhang-Dev · 2025-03-18T09:13:37Z

/azp run

azure-pipelines · 2025-03-18T09:13:44Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

nasc17 · 2025-03-20T17:21:35Z

Removed BreakingChange-Go-Sdk, passing in checks

openapi-pipeline-app · 2025-04-15T16:57:11Z

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

…quent characters in a name can be letters, digits (0-9), or underscores. Database name length must be less than 32 characters

openapi-pipeline-app · 2025-04-28T16:30:27Z

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

nasc17 · 2025-04-29T19:17:43Z

@msyyc could you please review?

msyyc

I am Python SDK owner. Approved for python.

…025-01-01-preview (Azure#33028) * Copy over previous preview api * Update versions * Updae readmes * Update title name * Update examples * Update descriptions * Update Tuning Options * DbTuning Init * fix semantic error * Lint Diff Fixes * Lint Diff Warnings * Update tuning params and examples * tuning configuration and index fixes * lint fixes * lint fixes * remove "x-ms-client-flatten": true, * lint fixes * Lint fixes * revert lint warning change * Add suppresion for tuning options api * update readme * Remove multi default api * Fix suppresion paths, cleanup readme * Revert "Fix suppresion paths, cleanup readme" This reverts commit 4c79ff5. * Put back single sever * Add missing server states * Database name must begin with a letter (a-z) or underscore (_). Subsequent characters in a name can be letters, digits (0-9), or underscores. Database name length must be less than 32 characters * revert change, not preview in TS.

TimLovellSmith · 2025-05-16T20:29:02Z

@gary-x-li @mikeharder is there some known issue with Avocado here for which avocado was suppressed?

mikeharder · 2025-05-17T23:20:53Z

@gary-x-li @mikeharder is there some known issue with Avocado here for which avocado was suppressed?

Azure/avocado#152

kazrael2119 · 2025-05-19T03:18:41Z

@nasc17 I noticed that your readme tag is incorrect and missing typescript configs for this version
I create a PR #34762 to fix it, could you help review?

BTW, please always remember to add the new flexible config in readme.typescript.md if you add a new flexible tag so that we can review if the new version has breaking changes

thanks

…025-01-01-preview (Azure#33028) * Copy over previous preview api * Update versions * Updae readmes * Update title name * Update examples * Update descriptions * Update Tuning Options * DbTuning Init * fix semantic error * Lint Diff Fixes * Lint Diff Warnings * Update tuning params and examples * tuning configuration and index fixes * lint fixes * lint fixes * remove "x-ms-client-flatten": true, * lint fixes * Lint fixes * revert lint warning change * Add suppresion for tuning options api * update readme * Remove multi default api * Fix suppresion paths, cleanup readme * Revert "Fix suppresion paths, cleanup readme" This reverts commit 4c79ff5. * Put back single sever * Add missing server states * Database name must begin with a letter (a-z) or underscore (_). Subsequent characters in a name can be letters, digits (0-9), or underscores. Database name length must be less than 32 characters * revert change, not preview in TS.

nasc17 added 8 commits March 3, 2025 10:26

Copy over previous preview api

579d70c

Update versions

31d4b88

Updae readmes

60dec43

Update title name

ac03213

Update examples

3baa6be

Update descriptions

f6dc368

Update Tuning Options

79d00b5

DbTuning Init

bd29ba0

nasc17 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Mar 5, 2025

nasc17 requested review from a team, msyyc, qiaozha and tadelesh as code owners March 5, 2025 21:47

microsoft-github-policy-service bot added the PostgreSQL label Mar 5, 2025

github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 5, 2025

AzureRestAPISpecReview added ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 5, 2025

nasc17 added 2 commits March 5, 2025 22:23

fix semantic error

01439ad

Lint Diff Fixes

628b281

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 6, 2025

nasc17 requested review from mattboentoro and nachoalonsoportillo March 17, 2025 15:11

tadelesh removed the BreakingChange-Go-Sdk label Mar 18, 2025

azure-sdk added the BreakingChange-Go-Sdk label Mar 18, 2025

mattboentoro approved these changes Mar 19, 2025

View reviewed changes

nasc17 removed the BreakingChange-Go-Sdk label Mar 20, 2025

microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Apr 7, 2025

Add missing server states

ea8af85

microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Apr 15, 2025

Database name must begin with a letter (a-z) or underscore (_). Subse…

02e9a72

…quent characters in a name can be letters, digits (0-9), or underscores. Database name length must be less than 32 characters

merge

bcfc354

ambrahma approved these changes Apr 29, 2025

View reviewed changes

revert change, not preview in TS.

bf07c86

msyyc approved these changes Apr 30, 2025

View reviewed changes

nasc17 merged commit b7df812 into Azure:main Apr 30, 2025
45 of 49 checks passed

nasc17 mentioned this pull request May 8, 2025

[AutoRelease] t2-postgresqlflexibleservers-2025-05-07-19592(can only be merged by SDK owner) Azure/azure-sdk-for-python#40938

Closed

nachoalonsoportillo mentioned this pull request May 22, 2025

Review of PostgreSQL swagger descriptions and examples #34864

Merged

9 tasks

mattboentoro mentioned this pull request Jun 30, 2025

Review request for Microsoft.DBforPostgreSQL to add version preview/2025-06-01-preview #35537

Merged

9 tasks

mikekistler mentioned this pull request Jul 28, 2025

Review request for Microsoft.DBforPostgreSQL to add version stable/2025-08-01 #36219

Merged

9 tasks

Conversation

nasc17 commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-sdk commented Mar 5, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

JiaqiZhang-Dev commented Mar 18, 2025

Uh oh!

azure-pipelines bot commented Mar 18, 2025

Uh oh!

nasc17 commented Mar 20, 2025

Uh oh!

openapi-pipeline-app bot commented Apr 15, 2025

Uh oh!

openapi-pipeline-app bot commented Apr 28, 2025

Uh oh!

nasc17 commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msyyc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TimLovellSmith commented May 16, 2025

Uh oh!

mikeharder commented May 17, 2025

Uh oh!

kazrael2119 commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

nasc17 commented Mar 5, 2025 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2025 •

edited

Loading

openapi-pipeline-app bot commented Mar 5, 2025 •

edited

Loading

azure-sdk commented Mar 5, 2025 •

edited by github-actions bot

Loading

nasc17 commented Apr 29, 2025 •

edited

Loading