Skip to content

misc fixes to oauth related api's on botservice swagger #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marstr merged 2 commits into from
Jul 5, 2018
Merged

misc fixes to oauth related api's on botservice swagger #3280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5c450a
misc fixes to oauth related api's on botservice swagger
Jun 20, 2018
ee2a286
remove resource group parameter from list auth providers
Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...ation/botservice/resource-manager/Microsoft.BotService/preview/2017-12-01/botservice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/BotServices/listServiceProviders": {
"/subscriptions/{subscriptionId}/providers/Microsoft.BotService/listAuthServiceProviders": {
Copy link
Member

@marstr marstr Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the other reference to the resource group parameter in this operation:
https://github.com/Azure/azure-rest-api-specs/pull/3280/files#diff-6e7e52c7a9eb6243152b8870ce21ddf4R700

Copy link
Member

@marstr marstr Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error that is currently causing CI to fail.

Copy link
Contributor Author

@swagatmishra2007 swagatmishra2007 Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see...thanks for pointing it out. the error in the ci build seemed puzzling.

"post": {
"tags": [
"ListServiceProviders"
Expand All @@ -696,9 +696,6 @@
}
},
"parameters": [
{
"$ref": "#/parameters/resourceGroupNameParameter"
},
{
"$ref": "#/parameters/apiVersionParameter"
},
Expand Down Expand Up @@ -1851,13 +1848,11 @@
"properties": {
"key": {
"type": "string",
"description": "Key for the Connection Setting Parameter.",
"readOnly": true
"description": "Key for the Connection Setting Parameter."
},
"value": {
"type": "string",
"description": "Value associated with the Connection Setting Parameter.",
"readOnly": true
"description": "Value associated with the Connection Setting Parameter."
}
},
"description": "Extra Parameter in a Connection Setting Properties to indicate service provider specific properties"
Expand All @@ -1868,6 +1863,11 @@
"type": "string",
"description": "Client Id associated with the Connection Setting."
},
"settingId": {
"type": "string",
"description": "Setting Id set by the service for the Connection Setting.",
"readOnly": true
},
"clientSecret": {
"type": "string",
"description": "Client Secret associated with the Connection Setting"
Expand Down
1 change: 0 additions & 1 deletion ...source-manager/Microsoft.BotService/preview/2017-12-01/examples/ListServiceProviders.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"parameters": {
"subscriptionId": "subscription-id",
"resourceGroupName": "OneResourceGroupName",
"api-version": "2017-01-01"
},
"responses": {
Expand Down