Storage Blob swagger to typespec migration#32527
Conversation
…into feature/blob-tsp
…es_from_url` TypeSpec Changes (#36311)
| @sharedRoute | ||
| @route("{blobName}?comp=properties&UpdateSequenceNumber") | ||
| op updateSequenceNumber is StorageOperation< | ||
| op setSequenceNumber is StorageOperation< |
There was a problem hiding this comment.
Why is this operation being renamed? and should it have been done in client.tsp?
|
@vincenttran-msft please regenerate the openapi spec based off of your recent commits. The typespec validation step is failing again. |
|
Hi @catalinaperalta , sorry about this. I was trying to get a Rust SDK PR merged through and our process was typically to hold the typespec change while in progress until ready to merge. Since we typically see red in the CI I did not think to stop and validate for at least the Typespec Validation Step. I have opened the following: #36594 which addresses the use of the As for the renames, we previously were using the If this was the incorrect solution, please let me know the correct path forward and I can go back and resolve all instances. I believe the reason why we landed on renames in Edit: I have since merged the above, to correct the use of |
|
@catalinaperalta, @lmazuel please see my response in internal email thread regarding this. These types of breaking changes that Vincent is making are going to need to keep happening as we develop the Rust SDK further. We are not considering this spec a stable spec until Rust is fully released. |
|
@vincenttran-msft please look at the errors in the typespec validation check and address. You need to regenerate the openapi spec like I mentioned in my earlier comments. @jalauzon-msft let's continue discussing in today's sync with Scott :) |
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.