[ACR] Update nodejs config to use 2018-02-preview api-version#3251
[ACR] Update nodejs config to use 2018-02-preview api-version#3251annatisch merged 2 commits intoAzure:masterfrom
Conversation
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
| @@ -7,7 +7,7 @@ Please also specify `--node-sdks-folder=<path to root folder of your azure-sdk-f | |||
| nodejs: | |||
There was a problem hiding this comment.
You may consider the following solution without updating the default so that you can limit the chagne to nodejs.
nodejs:
azure-arm: true
package-name: azure-arm-containerregistry
package-version: 2.3.0
output-folder: $(node-sdks-folder)/lib/services/containerRegistryManagement
generate-license-txt: true
generate-package-json: true
generate-readme-md: true
input-file:
- Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
- Microsoft.ContainerRegistry/preview/2018-02-01-preview/containerregistry_build.json There was a problem hiding this comment.
@djyou - I'm ready to sign-off and merge - let me know if you wish to push this suggested change to the nodejs config before I do so :)
There was a problem hiding this comment.
Updated as suggested. This may however introduce more maintenance confusion though. /cc @daschult
There was a problem hiding this comment.
Thanks @djyou - does this mean that you only want to publish the Nodejs SDK at this time?
There was a problem hiding this comment.
Yes, since it's a preview version, we will publish the SDK when necessary.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger