Skip to content

Add Microsoft.Mission spec to public repo#32359

Merged
tgoodyear merged 117 commits intomainfrom
2024-11-01-preview-Microsoft-Mission
Jul 25, 2025
Merged

Add Microsoft.Mission spec to public repo#32359
tgoodyear merged 117 commits intomainfrom
2024-11-01-preview-Microsoft-Mission

Conversation

@jchavaherrera
Copy link
Member

@jchavaherrera jchavaherrera commented Jan 28, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 28, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 28, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 28, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Mission
JavaScript @azure/arm-virtualenclaves
Python azure-mgmt-virtualenclaves
Java com.azure.resourcemanager:azure-resourcemanager-virtualenclaves
Go sdk/resourcemanager/virtualenclaves/armvirtualenclaves

@jchavaherrera
Copy link
Member Author

We are having the error [MISSING_APIS_IN_DEFAULT_TAG], this is being caused by a deprecated version of the API, we would like to have that error suppressed

@tgoodyear
Copy link
Member

Pending approval from Microsoft.Mission leadership team to approve transition to Public Preview

@tgoodyear
Copy link
Member

tgoodyear commented Jul 24, 2025

This PR moves the specs from azure-rest-api-specs-pr into azure-rest-api-specs as part of the process for moving towards Public Preview. There are no differences between the spec in azure-rest-api-specs-pr/RPSaaSMaster and this PR. Feature control is maintained by AFEC, will not be removed until all other Public Preview gates are satisfied.

As discussed in the azure-rest-api-specs-pr comments, Avocado is suppressed since it does not handle moves/renames. Some operations were renamed in 2025-05-01-preview.

@gary-x-li
Copy link
Contributor

Can you fix the TypeSpec Validation failure?

Renamed TypeScript package directory and name to use 'arm-placeholder' instead of 'armplaceholder'. Added C# emitter configuration with Azure flavor, output directory, and namespace settings to align with SDK generation standards.
Replaced placeholder values in tspconfig.yaml with Virtual Enclaves-specific package directories, namespaces, and service names for Go, Python, Java, TypeScript, and C# emitters. This aligns the configuration with the Virtual Enclaves service for correct SDK generation.
Changed the @azure-tools/typespec-go service-dir from 'sdk/resourcemanager/virtualenclaves/armvirtualenclaves' to 'sdk/resourcemanager/virtualenclaves' to correct the SDK output directory configuration.
Changed the 'service-dir' default value in tspconfig.yaml from 'sdk/placeholder' to 'sdk/virtualenclaves' to reflect the correct SDK output directory.
Changed the service-dir default value from 'sdk/virtualenclaves' to 'sdk/resourcemanager/virtualenclaves' to ensure correct SDK emission path.
Changed the default value of service-dir from 'sdk/resourcemanager/virtualenclaves' to 'sdk/virtualenclaves' to reflect the correct SDK directory structure.
@jchavaherrera
Copy link
Member Author

Can you fix the TypeSpec Validation failure?

@gary-x-li We fix the TypeSpec Validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version new-rp-namespace PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants