Skip to content

VM, NIC & Disk Hydration API changes for version 2025-02-01-preview#32308

Merged
shraddhasun merged 7 commits intoAzure:mainfrom
yujiaucr:users/jiyu3/HydrationApi2
Feb 5, 2025
Merged

VM, NIC & Disk Hydration API changes for version 2025-02-01-preview#32308
shraddhasun merged 7 commits intoAzure:mainfrom
yujiaucr:users/jiyu3/HydrationApi2

Conversation

@yujiaucr
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

neerajdixit-msft2 and others added 3 commits January 23, 2025 21:49
…-02-01-preview (Azure#20735)

* VM, NIC & Disk Hydration API changes for version 2025-02-01-preview

* Disk resizing changes
---------

Co-authored-by: Manasi <magund@microsoft.com>
Co-authored-by: Neeraj Dixit <ndixit@microsoft.com>
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 23, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 23, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.AzureStackHCI
Microsoft.AzureStackHCI-StackHCIVM
Microsoft.AzureStackHCI

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 24, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 24, 2025
Anchal Verma and others added 4 commits January 30, 2025 23:06
@mancbg
Copy link
Contributor

mancbg commented Jan 31, 2025

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@shraddhasun shraddhasun merged commit db1cf02 into Azure:main Feb 5, 2025
29 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
…zure#32308)

* VM, NIC & Disk Hydration & Disk Resizing API changes for version 2025-02-01-preview (Azure#20735)

* VM, NIC & Disk Hydration API changes for version 2025-02-01-preview

* Disk resizing changes
---------

Co-authored-by: Manasi <magund@microsoft.com>
Co-authored-by: Neeraj Dixit <ndixit@microsoft.com>

* Fix cspell and generated stackhcivm.json file

* Revert Disk resizing changes from 2025-02-01-preview APIs

Reverted change follows:
https://github.com/neerajdixit-msft2/azure-rest-api-specs-pr/pull/2/files

* Add Day2 NIC support and provisioning status for NSG

* Fix typespec failures

* Disk resize changes (Azure#1)

* disk resize changes

* remove dynamic flag

---------

Co-authored-by: Manasi <magund@microsoft.com>

---------

Co-authored-by: neerajdixit-msft2 <123779900+neerajdixit-msft2@users.noreply.github.com>
Co-authored-by: Manasi <magund@microsoft.com>
Co-authored-by: Neeraj Dixit <ndixit@microsoft.com>
Co-authored-by: Anchal Verma <anchalverma@microsoft.com>
Co-authored-by: aanchalv05 <96567691+aanchalv05@users.noreply.github.com>
Co-authored-by: Manasi Gund <manasigund22@gmail.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…zure#32308)

* VM, NIC & Disk Hydration & Disk Resizing API changes for version 2025-02-01-preview (Azure#20735)

* VM, NIC & Disk Hydration API changes for version 2025-02-01-preview

* Disk resizing changes
---------

Co-authored-by: Manasi <magund@microsoft.com>
Co-authored-by: Neeraj Dixit <ndixit@microsoft.com>

* Fix cspell and generated stackhcivm.json file

* Revert Disk resizing changes from 2025-02-01-preview APIs

Reverted change follows:
https://github.com/neerajdixit-msft2/azure-rest-api-specs-pr/pull/2/files

* Add Day2 NIC support and provisioning status for NSG

* Fix typespec failures

* Disk resize changes (Azure#1)

* disk resize changes

* remove dynamic flag

---------

Co-authored-by: Manasi <magund@microsoft.com>

---------

Co-authored-by: neerajdixit-msft2 <123779900+neerajdixit-msft2@users.noreply.github.com>
Co-authored-by: Manasi <magund@microsoft.com>
Co-authored-by: Neeraj Dixit <ndixit@microsoft.com>
Co-authored-by: Anchal Verma <anchalverma@microsoft.com>
Co-authored-by: aanchalv05 <96567691+aanchalv05@users.noreply.github.com>
Co-authored-by: Manasi Gund <manasigund22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants