Add missing debugsend and patch operation for NotificationHub resource by blocphan · Pull Request #3215 · Azure/azure-rest-api-specs

blocphan · 2018-06-12T00:49:56Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-06-12T00:51:07Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2737

AutorestCI · 2018-06-12T00:51:24Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2897

AutorestCI · 2018-06-12T00:51:51Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#187

AutorestCI · 2018-06-12T00:52:50Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1369

AutorestCI · 2018-06-12T00:54:21Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2036

jianghaolu · 2018-06-12T19:31:39Z

...tionhubs/resource-manager/Microsoft.NotificationHubs/stable/2017-04-01/notificationhubs.json

+        },
+        "operationId": "NotificationHubs_DebugSend",
+        "description": "test send a push notification",
+        "parameters": [


Missing parameter 'subscriptionId'

jianghaolu · 2018-06-12T19:38:12Z

...osoft.NotificationHubs/stable/2017-04-01/examples/NotificationHubs/NotificationHubPatch.json

+      "notificationHubName": "sdk-notificationHubs-8708",
+      "api-version": "2017-04-01",
+      "subscriptionId": "29cfa613-cbbc-4512-b1d6-1b3a92c7fa40",
+      "properties": {


This should be "parameters"

jianghaolu · 2018-06-12T19:39:26Z

...t.NotificationHubs/stable/2017-04-01/examples/NotificationHubs/NotificationHubDebugSend.json

+        "subscriptionId": "29cfa613-cbbc-4512-b1d6-1b3a92c7fa40"
+    },
+    "responses": {
+        "200": {


"200" is not a valid response defined in the spec.

jianghaolu · 2018-06-12T19:40:22Z

...t.NotificationHubs/stable/2017-04-01/examples/NotificationHubs/NotificationHubDebugSend.json

+        "notificationHubName": "nh-sdk-hub",
+        "api-version": "2017-04-01",
+        "subscriptionId": "29cfa613-cbbc-4512-b1d6-1b3a92c7fa40"
+    },


Required parameter "parameters" missing.

jianghaolu · 2018-06-12T19:47:30Z

specification/notificationhubs/resource-manager/readme.md

 ### Basic Information
 These are the global settings for the NotificationHubs API.

+directive:


The directives must be defined in the yaml section for the tag containing this definition

blocphan added 2 commits May 11, 2018 14:26

Add suppressions for linting errors. Approved by Gaurav

7168a53

Add debugsend and NH patch operation

01edec5

azuresdkci assigned jianghaolu Jun 12, 2018

azuresdkci requested a review from jianghaolu June 12, 2018 00:51

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR notificationhubs/resource-manager] Add missing debugsend and patch operation for NotificationHub resource Azure/azure-sdk-for-python#2724

Merged

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR notificationhubs/resource-manager] Add missing debugsend and patch operation for NotificationHub resource Azure/azure-sdk-for-node#2977

Merged

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR notificationhubs/resource-manager] Add missing debugsend and patch operation for NotificationHub resource AutorestCI/azure-libraries-for-java#244

Merged

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR notificationhubs/resource-manager] Add missing debugsend and patch operation for NotificationHub resource Azure/azure-sdk-for-ruby#1359

Merged

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR notificationhubs/resource-manager] Add missing debugsend and patch operation for NotificationHub resource Azure/azure-sdk-for-go#2017

Merged

jianghaolu suggested changes Jun 12, 2018

View reviewed changes

blocphan added 7 commits June 12, 2018 14:20

Fix build error due to missing parameterId

0238c42

Fix build errors

b6cd19c

Fix more errors

2f2ca99

Fix build errors due to mismatch parameters

3b57f48

Fix error with missing parameters value for DebugSend

edb81a4

Change DebugSendResult from string to object

3e94782

Fix DebugSend build errors

65b541d

jianghaolu approved these changes Jun 13, 2018

View reviewed changes

jianghaolu merged commit 289cf40 into Azure:master Jun 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing debugsend and patch operation for NotificationHub resource#3215

Add missing debugsend and patch operation for NotificationHub resource#3215
jianghaolu merged 9 commits intoAzure:masterfrom
blocphan:master

blocphan commented Jun 12, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Jun 12, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Jun 12, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Jun 12, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Jun 12, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Jun 12, 2018 •

edited

Loading

Uh oh!

jianghaolu Jun 12, 2018

Uh oh!

blocphan Jun 13, 2018

Uh oh!

jianghaolu Jun 12, 2018

Uh oh!

jianghaolu Jun 12, 2018

Uh oh!

jianghaolu Jun 12, 2018

Uh oh!

jianghaolu Jun 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

blocphan commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jun 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

jianghaolu Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

blocphan Jun 13, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blocphan commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading