add long running operation result to the botservice swagger#3214
add long running operation result to the botservice swagger#3214swagatmishra2007 wants to merge 2 commits intoAzure:masterfrom swagatmishra2007:master
Conversation
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-goA PR has been created for you: |
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Please check the API for its long running-ness
There was a problem hiding this comment.
GET operations MUST not be long running. If the resource takes a long time to come up, please user provisioning states.
There was a problem hiding this comment.
i added the x-ms-longrunning attribute as autorest was complaining about it, so i have now removed it.
instead of a long running operation we merely want a way to query for an operation result. the operation result operation isnt longrunning itself. sorry for the confusion.
| "200": { | ||
| "description": "If the operation completed successfully, the service should return 200 (OK)." | ||
| }, | ||
| "202": { |
There was a problem hiding this comment.
On similar lines, not sure if the service is supposed to return a 202 response. 202 status code corresponds to accepted, i.e., the operation as been accepted but not completed. A non-long running GET operation MUST finish and return right away.
Please confirm is the service has undergone an ARM/API review
There was a problem hiding this comment.
the above pattern is directly taken from azure-rest-api-specs\specification\analysisservices\resource-manager\Microsoft.AnalysisServices\stable\2016-05-16\analysisservices.json (please see line 425)
There was a problem hiding this comment.
The file you pointed out is incorrect too. 202 is simply not acceptable for a GET operation. Does your service actually return that status code?
|
@swagatmishra2007 Please address the comments soon, the PR will be closed if not active. |
|
it seems like we need further discussion on how to get the semantics working here. We were looking at the analysis services swagger and like you pointed out , they arent doing the right thing too. we will follow up on email and then send out a new pr. i am closing this for now. thanks for your comments @dsgouda |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
3 participants
No description provided.