Skip to content

[Storage] update the example of management policy since format change #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anuchandy merged 1 commit into from
Jun 11, 2018
Merged

[Storage] update the example of management policy since format change #3197

anuchandy merged 1 commit into from
Jun 11, 2018

Conversation

@blueww
Copy link
Member

@blueww blueww commented Jun 8, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

Since the management policy format change, update the swagger example.
This won't impact the api in swagger.
Update the example are mainly for the rest doc generate.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@bsiegel bsiegel added the review label Jun 8, 2018
@azuresdkci azuresdkci requested a review from hovsepm June 8, 2018 03:29
yzheng-msft
yzheng-msft reviewed Jun 8, 2018
View reviewed changes
...Microsoft.Storage/preview/2018-03-01-preview/examples/StorageAccountGetManagementPolicy.json Outdated
Copy link

@yzheng-msft yzheng-msft Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Wei, small issue here. TierToCool days should be smaller than TierToArchive days, otherwise there would be a run time error. can you make change it from 1000 to 30?

yzheng-msft
yzheng-msft reviewed Jun 8, 2018
View reviewed changes
...Microsoft.Storage/preview/2018-03-01-preview/examples/StorageAccountSetManagementPolicy.json Outdated
Copy link

@yzheng-msft yzheng-msft Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the comment above

@hovsepm
Copy link
Contributor

hovsepm commented Jun 8, 2018

LGTM. Please let me know when the comments from @yzheng-msft will be addressed to merge the PR.

@azuresdkci azuresdkci assigned lmazuel and unassigned hovsepm Jun 8, 2018
@azuresdkci azuresdkci requested a review from lmazuel June 8, 2018 21:34
@blueww
Copy link
Member Author

blueww commented Jun 11, 2018

@hovsepm , @yzheng-msft , all comments has been resolved.
Would you please help to merge the PR?
Thanks!

@anuchandy anuchandy self-assigned this Jun 11, 2018
@anuchandy anuchandy merged commit ff32ccf into Azure:master Jun 11, 2018
@blueww blueww mentioned this pull request Jun 12, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

+2 more reviewers

@yzheng-msft yzheng-msft yzheng-msft left review comments

@hovsepm hovsepm hovsepm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lmazuel lmazuel

@anuchandy anuchandy

Labels

review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@blueww @AutorestCI @hovsepm @anuchandy @yzheng-msft @bsiegel @lmazuel @azuresdkci