Skip to content

Conversation

@quintinb
Copy link
Contributor

@quintinb quintinb commented Jun 2, 2018

Changes from the 2018-03-30-preview version include:

  1. Add AlternativeMediaId to StreamingLocator and to the LiveEvent preview.
  2. Add CorrelationData to the Job entity to allow customers to supply data that will be echoed in the forthcoming JobCompletedEvent.
  3. Change Type of ContentKeys in StreamingLocatorProperty from StreamingLocatorUserDefinedContentKey to StreamingLocatorContentKey. This allows the ContentKeyId information to be available when a user creates a StreamingLocator even for ContentKeys created by MediaServices.
  4. Rename CustomLicenseAcquisitionUrlTemplate to CustomKeyAcquisitionUrlTemplate for EnvelopeEncryption.

Changes from the 2018-03-30-preview version include:

1. Add AlternativeMediaId to StreamingLocator and to the LiveEvent preview.
2. Add CorrelationData to the Job entity to allow customers to supply data that will be echoed in the forthcoming JobCompletedEvent.
3. Change Type of ContentKeys in StreamingLocatorProperty from StreamingLocatorUserDefinedContentKey to StreamingLocatorContentKey.  This allows the ContentKeyId information to be available when a user creates a StreamingLocator even for ContentKeys created by MediaServices.
4. Rename CustomLicenseAcquisitionUrlTemplate to CustomKeyAcquisitionUrlTemplate for EnvelopeEncryption.
@AutorestCI
Copy link

AutorestCI commented Jun 2, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2798

@AutorestCI
Copy link

AutorestCI commented Jun 2, 2018

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/readme.md', '--multiapi', '--ruby', '--ruby-sdks-folder=/tmp/tmp2aigg_p8/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4280).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (3.0.20->3.0.20)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2018-06-preview"} .
Processing batch task - {"tag":"package-2018-03-preview"} .

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/streamingservice.json:1654:4 ($.definitions.ODataError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/StreamingPoliciesAndStreamingLocators.json:649:4 ($.definitions.ODataError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/Encoding.json:1512:4 ($.definitions.ODataError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/ContentKeyPolicies.json:741:4 ($.definitions.ODataError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/Assets.json:135:4 ($.definitions.ODataError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/Accounts.json:210:4 ($.definitions.ODataError)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/streamingservice.json:1678:4 ($.definitions.ApiError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/StreamingPoliciesAndStreamingLocators.json:674:4 ($.definitions.ApiError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/Encoding.json:1537:4 ($.definitions.ApiError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/ContentKeyPolicies.json:766:4 ($.definitions.ApiError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/Assets.json:160:4 ($.definitions.ApiError)
    - file:///tmp/tmp2aigg_p8/rest/specification/mediaservices/resource-manager/Microsoft.Media/preview/2018-03-30-preview/Accounts.json:235:4 ($.definitions.ApiError)
Process() cancelled due to exception : Cancellation requested.
Failure during batch task - {"tag":"package-2018-03-preview"} -- Cancellation requested..
  Cancellation requested.

@AutorestCI
Copy link

AutorestCI commented Jun 2, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3046

@AutorestCI
Copy link

AutorestCI commented Jun 2, 2018

Automation for azure-libraries-for-java

A PR has been created for you:
AutorestCI/azure-libraries-for-java#221

@AutorestCI
Copy link

AutorestCI commented Jun 2, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2100

@marstr marstr requested a review from ravbhatnagar June 5, 2018 15:47
@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 5, 2018
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When comparing the two API Versions, there aren't many changes. Nothing jumped out as troublesome.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2018
@ravbhatnagar
Copy link
Contributor

Signing off from ARM

@marstr
Copy link
Member

marstr commented Jun 6, 2018

@quintinb, are these changes publicly available and ready for me to merge?

@marstr
Copy link
Member

marstr commented Jun 12, 2018

Ping @quintinb

@marstr
Copy link
Member

marstr commented Jun 15, 2018

Closing as stale. Ping this thread if it should be re-opened or submit a new PR.

@marstr marstr closed this Jun 15, 2018
@quintinb
Copy link
Contributor Author

Can this be merged now please?

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants