Conversation
danieljurek
requested review from
benbp,
mikeharder and
weshaggard
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
Member
Author
|
@mikeharder I'm merging this now as it fixes the immediate issue. We can do a longer term fix in the near future. |
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Oct 29, 2024
* fail-fast: false * Write-Host instead of Write-Error, judge failure from exit code * Option 1: Continue processing when an error is written out. Nonzero exit code will fail the step. * Undo eng/scripts/Logging-Functions.ps1 * Revert typespec-requirement.yaml * Put ErrorActionPreference in the right place
haagha
pushed a commit
that referenced
this pull request
Nov 19, 2024
* fail-fast: false * Write-Host instead of Write-Error, judge failure from exit code * Option 1: Continue processing when an error is written out. Nonzero exit code will fail the step. * Undo eng/scripts/Logging-Functions.ps1 * Revert typespec-requirement.yaml * Put ErrorActionPreference in the right place
pjpatel12
pushed a commit
to pjpatel12/azure-rest-api-specs
that referenced
this pull request
Apr 29, 2025
* fail-fast: false * Write-Host instead of Write-Error, judge failure from exit code * Option 1: Continue processing when an error is written out. Nonzero exit code will fail the step. * Undo eng/scripts/Logging-Functions.ps1 * Revert typespec-requirement.yaml * Put ErrorActionPreference in the right place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues identified:
Within a job, TSV.ps1 is now failing fast when the first spec fails, instead of verifying all specs and collecting the errors.
The parallel jobs are also configured to fail fast, so they all cancel when one fails, which we don't want either.
With fixes:
TypeSpec Validation now shows an error, continues processing and then fails the build:
TypeSpec Validation All now shows an error, continues processing, and then fails the build and all jobs run until completion: