Skip to content

[DO NOT MERGE] Test basic failure case for TypeScript validation #31245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danieljurek wants to merge 52 commits into from
Closed

[DO NOT MERGE] Test basic failure case for TypeScript validation #31245

danieljurek wants to merge 52 commits into from

Conversation

@danieljurek
Copy link
Member

@danieljurek danieljurek commented Oct 25, 2024

Testing #31033

wanlwanl and others added 30 commits October 25, 2024 14:20
@wanlwanl @danieljurek
test breaking change mlc in js (#3451)
43cb00b 
* `

* `

* Revert "`"

This reverts commit c26fc6a.
@Alancere @danieljurek
Update specificationRepositoryConfiguration.json (#3457)
b3b9f1a
@msyyc @danieljurek
Update specificationRepositoryConfiguration.json (#3459)
808ea5f
@raych1 @danieljurek
Update specificationRepositoryConfiguration.json (#3462)
96b6c82 
Revert python repo branch change as it was deleted.
@msyyc @danieljurek
Update specificationRepositoryConfiguration.json (#3463)
1ebe623
@danieljurek
Migrate typespec-validation.yml to GH Actions
dba759b
@danieljurek
path, fetch depth
4136688
@danieljurek
Introduce error
bab1ae6
@danieljurek
Test a feature that AI says will collapse logs (doubtful it'll work)
d923e56
@danieljurek
Revert "Test a feature that AI says will collapse logs (doubtful it'l…
0e71fc9 
…l work)"

This reverts commit 04aed83.
@danieljurek
Log $LASTEXITCODE
6839fbb
@danieljurek
Invalid syntax
ec7af3d
@danieljurek
Use error logging, remove continue-on-error because that is different…
be5efe7 
… behavior in GitHub Actions compared to ignoreLASTEXITCODE
@danieljurek
Errors also get annotations in GitHub Actions
985bf9b
@danieljurek
String replacement
407cb5e
@danieljurek
Revert Logging-Functions.ps1
e1ec118
@danieljurek
Test composite action
b32b546
@danieljurek
File location
1057f5d
@danieljurek
Invocation
8bdee66
@danieljurek
Add typespec-validation-all.yml
9eba441
@danieljurek
Migrate typespec-validation-all.yml
92e359b
@danieljurek
Revert main.tsp invalid spec
2723721
@danieljurek
fetch-depth: 2
d232bb5
@danieljurek
Long paths
e7b871b
@danieljurek
checkout@v4
772ef9f
@danieljurek
Remove pipelines
a154939
@danieljurek
*.yml -> *.yaml
c20eb68
@danieljurek
Do not change specificationRepositoryConfiguration.json
7856ddf
@danieljurek
Job names (for checks)
4f904de
@danieljurek
Add Skip/Take logic and matrix
0b7b6a6
danieljurek and others added 20 commits October 25, 2024 14:20
@danieljurek
Remove "shell"
906a8a2
@danieljurek
Try defaults.run.shell (unlikely to work)
d49e44f
@danieljurek
bash
95a6cc3
@danieljurek
Name for actions/setup-node@v4 does not appear in the logs. Remove.
62a57b5
@danieljurek
Use sharding semantics
7109da1
@danieljurek
Shard
e4410d9
@danieljurek
Review feedback
36de665
@danieljurek
Review feedback
5f1b7c6
@danieljurek
+1
a088013
@danieljurek
Revert "Shard"... Display is confusing because it starts at 0 and doe…
889143e 
…sn't reach total-shards. Math is not allowed in expressions.

This reverts commit 035bec73044d60c07307fd6efc19b7295258a507.
@danieljurek
Shard only if TotalShards > 0
6c836b3
@danieljurek
Remove description (schema validaiton does not pass, let's see what G…
3b50e1a 
…H Actions says)
@danieljurek
The description property is not absolutely required by GH Actions a…
ecaf771 
…t this time but adding back in because schema requires it.
@danieljurek
Add array functions and tests
34a7d4b
@danieljurek
Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they ar…
a316274 
…e accurate)
@mikeharder
Add trailing newline
be61a9c
@mikeharder
Add trailing newline
2886209
@danieljurek @mikeharder
Update .github/workflows/typespec-validation.yaml
7fa3248 
Co-authored-by: Mike Harder <[email protected]>
@danieljurek
Review feedback
4f4cfd9
@danieljurek
Trivial change which produces an error
4da786d
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 25, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 25, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/contoso/armcontoso https://apiview.dev/Assemblies/Review/19034274c42f494b900a3f8af06c5461?revisionId=7a1915365fef43ba9f5870aeca3a19b3
Java azure-resourcemanager-contoso https://apiview.dev/Assemblies/Review/f958535e0c7e4c1e85a46c1363c6e2bb?revisionId=adc5c3f5bc8d402e8bae9394d25fe0c4
JavaScript @azure/arm-contoso https://apiview.dev/Assemblies/Review/7667e852608e438dbcca91be6fd43b63?revisionId=6836525aa87c4615abc494078a1ba73e
.Net Azure.ResourceManager.Contoso https://apiview.dev/Assemblies/Review/7b224f26902a447c92903baab61d49c7?revisionId=ae5a7f40dcb548bb874b40bc96db8f0e

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Oct 25, 2024
This was referenced Oct 25, 2024
Closed
Closed
Closed
Closed
Closed
@danieljurek
Copy link
Member Author

danieljurek commented Oct 25, 2024 •
edited
Loading

This succeeded served its purpose. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder will be requested when the pull request is marked ready for review mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp benbp will be requested when the pull request is marked ready for review benbp is a code owner

@raych1 raych1 Awaiting requested review from raych1 raych1 will be requested when the pull request is marked ready for review raych1 is a code owner

@maririos maririos Awaiting requested review from maririos maririos will be requested when the pull request is marked ready for review maririos is a code owner

Assignees

No one assigned

Labels

TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@danieljurek @AzureRestAPISpecReview @wanlwanl @Alancere @msyyc @raych1 @mikeharder