Rename resource "ShortTermRetentionPolicy"->"BackupShortTermRetentionPolicy" to align with "BackupLongTermRetentionPolicy"#3122
Merged
jhendrixMSFT merged 10 commits intoAzure:masterfrom May 23, 2018
adeal:master
Merged
Rename resource "ShortTermRetentionPolicy"->"BackupShortTermRetentionPolicy" to align with "BackupLongTermRetentionPolicy"#3122jhendrixMSFT merged 10 commits intoAzure:masterfrom adeal:master
jhendrixMSFT merged 10 commits intoAzure:masterfrom
adeal:master
Conversation
jaredmoo
approved these changes
May 22, 2018
Contributor
jaredmoo
left a comment
There was a problem hiding this comment.
It also aligns with backupShortTermRetentionPolicies in the URI :)
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
This was referenced May 22, 2018
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Member
|
There are a few examples missing response bodies for 202 status codes, see https://travis-ci.org/Azure/azure-rest-api-specs/jobs/382401500. I know it wasn't introduced in this PR, is there an issue tracking fixing them? It would be awesome to have the model validator clean. |
jhendrixMSFT
approved these changes
May 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger