[Azure Search] Add autocomplete to data plane spec for 2017-11-11-Preview#3106
[Azure Search] Add autocomplete to data plane spec for 2017-11-11-Preview#3106sarangan12 merged 7 commits intoAzure:masterfrom mhko:auto
Conversation
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "parameters": { | |||
There was a problem hiding this comment.
This looks the same as the GET example. That can't be right -- most of these parameters should be in the request body, no? Did this pass validation?
There was a problem hiding this comment.
Yes, it does pass validation. I think the validation just checks the existence of example. In the entire spec undo this repo, I did not find an example where parameters are passed in the request body.
There was a problem hiding this comment.
| "name": "AutocompleteMode", | ||
| "modelAsString": false | ||
| }, | ||
| "x-ms-parameter-location": "method", |
There was a problem hiding this comment.
I don't think you need x-ms-parameter-location for parameters that are inline with the operation.
There was a problem hiding this comment.
You are right. I don't think it's needed.
| "description": "Autocomplete mode." | ||
| }, | ||
| { | ||
| "name":"search", |
There was a problem hiding this comment.
Maybe the search parameter should be first. I think it's the first parameter for Search and Suggest. I would argue it's the most important parameter.
| "in": "query", | ||
| "required": true, | ||
| "type": "string", | ||
| "enum": [ |
There was a problem hiding this comment.
There is already an AutocompleteMode enum definition later in the file. Can this parameter definition refer to that type instead of re-defining it?
There was a problem hiding this comment.
I tried that. Doing so somehow makes AutocompleteMode a generic object type.
There was a problem hiding this comment.
Too bad. Doing it this way still results in only one generated AutocompleteMode enum though, right?
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
…ion' on the autocompleteMode parameter.
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "parameters": { | |||
There was a problem hiding this comment.
payload for Post.
| "highlightPostTag": "</em>", | ||
| "highlightPreTag": "<em>", | ||
| "minimumCoverage": 80, | ||
| "searchFields": ["title", "description"], |
There was a problem hiding this comment.
searchFields is an IList in the C# SDK, but it's still a string as far as Swagger is concerned, right?
| "highlightPostTag": "</em>", | ||
| "highlightPreTag": "<em>", | ||
| "minimumCoverage": 80, | ||
| "searchFields": ["title", "description"], |
There was a problem hiding this comment.
Same as above. Even in Search and Suggest POST, searchFields is a comma-separated string.
…ples for autocomplete.
|
@sarangan12 Please review ASAP. This PR contains spec changes for a new feature called Autocomplete. We are announcing the Public Preview of this feature tomorrow, May 22nd. We'd like to generate the SDK from Azure/master by then. |
4 participants
Add swagger spec for the new autocomplete API to 2017-11-11-preview.
@brjohnstmsft, @jhendrixMSFT, @Yahnoosh, @natinimni
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger