Skip to content

[AKS] add POST endpoint for fetching accessProfiles #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hovsepm merged 5 commits into from
May 21, 2018
Merged

[AKS] add POST endpoint for fetching accessProfiles #3098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c1665f
[AKS] add POST endpoint for fetching accessProfiles
mboersma May 16, 2018
a86af5d
Mark GET endpoint for accessProfiles as deprecated
mboersma May 18, 2018
14544bf
Bump package version
mboersma May 18, 2018
72b668f
Deprecate the intended endpoint
mboersma May 18, 2018
a69eb4b
Rename to GetAccessProfile
mboersma May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...icrosoft.ContainerService/stable/2017-08-31/examples/ManagedClustersGetAccessProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"api-version": "2017-08-31",
"subscriptionId": "subid1",
"resourceGroupName": "rg1",
"resourceName": "clustername1",
"roleName": "clusterUser"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/subid1/resourcegroups/rg1/providers/Microsoft.ContainerService/managedClusters/clustername1/accessProfiles/clusterUser",
"location": "location1",
"name": "clusterUser",
"properties": {
"kubeConfig": "kubeConfig1"
},
"type": "Microsoft.ContainerService/ManagedClusters/AccessProfiles"
}
}
}
}
55 changes: 54 additions & 1 deletion ...rvices/resource-manager/Microsoft.ContainerService/stable/2017-08-31/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,67 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/accessProfiles/{roleName}/listCredential": {
"post": {
Copy link
Copy Markdown
Member

@lmazuel lmazuel May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboersma If this operation is preferred to ManagedClusters_GetAccessProfiles, you should declare it as deprecated (deprecated: True and update the description to say something generic like "Use ListCredential instead").

Copy link
Copy Markdown
Member Author

@mboersma mboersma May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmazuel done.

"tags": [
"ManagedClusters"
],
"operationId": "ManagedClusters_GetAccessProfile",
"summary": "Gets an access profile of a managed cluster.",
"description": "Gets the accessProfile for the specified role name of the managed cluster with a specified resource group and name.",
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the managed cluster resource."
},
{
"name": "roleName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the role for managed cluster accessProfile resource."
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ManagedClusterAccessProfile"
}
}
},
"x-ms-examples": {
"Get Managed Cluster": {
"$ref": "./examples/ManagedClustersGetAccessProfile.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/accessProfiles/{roleName}": {
"get": {
"tags": [
"ManagedClusters"
],
"operationId": "ManagedClusters_GetAccessProfiles",
"summary": "Gets access profile of a managed cluster.",
"description": "Gets the accessProfile for the specified role name of the managed cluster with a specified resource group and name.",
"deprecated": true,
"description": "Use ManagedClusters_GetAccessProfile instead.",
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
Expand Down
2 changes: 1 addition & 1 deletion specification/containerservices/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ python:
payload-flattening-threshold: 2
namespace: azure.mgmt.containerservice
package-name: azure-mgmt-containerservice
package-version: 3.0.1
package-version: 3.1.0
clear-output-folder: true
```
``` yaml $(python) && $(python-mode) == 'update'
Expand Down