-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding Media Services Event Grid schema #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
|
@jonpayne from the description what I understand is - this model represents the schema of event that media-services internally send to event grid when it is enabled. From customers point of view, the way they use is, they use event grid data plane to retrieve the event in string/json format and then uses this model to deserialize the string to POJO. is my understanding correct? |
|
@anuchandy This is the schema for the events Media Services will send to customers, via Azure Event Grid. The documentation for these events is here: |
kalyanaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonpayne , can you please add a reference to this JSON file in the eventgrid/data-plane/readme.md file? As an example, you can look at other existing publishers such as ContainerRegistry or ServiceBus.
|
@anuchandy , to answer your previous question: Yes, customers can create an event subscription in EventGrid to subscribe to these events (e.g. an Azure Function can be the destination of this event subscription). Once the event JSON is received there, it can be deserialized into an "EventGridEvent", and the Data portion of the EventGridEvent can be deserialized using the new model that @jonpayne has added in this PR. |
kalyanaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it will be great to use the same directory structure convention used by other existing publishers.
kalyanaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger