Skip to content

Conversation

@jonpayne
Copy link
Member

@jonpayne jonpayne commented May 17, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented May 17, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2546

@AutorestCI
Copy link

AutorestCI commented May 18, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1870

@AutorestCI
Copy link

AutorestCI commented May 18, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented May 18, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2800

@anuchandy
Copy link
Member

@jonpayne from the description what I understand is - this model represents the schema of event that media-services internally send to event grid when it is enabled. From customers point of view, the way they use is, they use event grid data plane to retrieve the event in string/json format and then uses this model to deserialize the string to POJO. is my understanding correct?

@jonpayne
Copy link
Member Author

@anuchandy This is the schema for the events Media Services will send to customers, via Azure Event Grid. The documentation for these events is here:
https://docs.microsoft.com/en-us/azure/media-services/latest/media-services-event-schemas?toc=%2fazure%2fevent-grid%2ftoc.json
@kalyanaj can provide more details.

Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonpayne , can you please add a reference to this JSON file in the eventgrid/data-plane/readme.md file? As an example, you can look at other existing publishers such as ContainerRegistry or ServiceBus.

@kalyanaj
Copy link
Contributor

@anuchandy , to answer your previous question: Yes, customers can create an event subscription in EventGrid to subscribe to these events (e.g. an Azure Function can be the destination of this event subscription). Once the event JSON is received there, it can be deserialized into an "EventGridEvent", and the Data portion of the EventGridEvent can be deserialized using the new model that @jonpayne has added in this PR.

Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it will be great to use the same directory structure convention used by other existing publishers.

Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants