Skip to content

Update Web Apps swagger with restore deleted site APIs#3096

Merged
annatisch merged 1 commit intoAzure:masterfrom
nking-1:master
May 23, 2018
Merged

Update Web Apps swagger with restore deleted site APIs#3096
annatisch merged 1 commit intoAzure:masterfrom
nking-1:master

Conversation

@nking-1
Copy link
Copy Markdown

@nking-1 nking-1 commented May 17, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented May 17, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented May 18, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1857

@annatisch
Copy link
Copy Markdown
Member

Thanks @Nking92 - are these new APIs? Or existing APIs that are already live and were missed in the spec?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented May 18, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented May 18, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpw0sjczgo/rest/specification/web/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpw0sjczgo/sdk', '--nodejs']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

@nking-1
Copy link
Copy Markdown
Author

nking-1 commented May 18, 2018

@annatisch These APIs are already live. I had them set to be hidden because we needed some bake time to test out the new feature before publishing it. Thanks!

@annatisch
Copy link
Copy Markdown
Member

@Nking92 - the README file for this spec is pointing to an older API version (package-2016-09). So the changes that you are making here will not actually be added into the generated SDKs. Is this your intension?
If not - please update the default package version tag in the README to point to the correct API version.
https://github.com/Nking92/azure-rest-api-specs/blob/cfed6a3302ef592095996f7320ba23eaf3b12579/specification/web/resource-manager/readme.md#basic-information

@nking-1
Copy link
Copy Markdown
Author

nking-1 commented May 23, 2018

@annatisch Yes, this is intentional for now. We're leaving the default version to the older one at the moment.

@annatisch
Copy link
Copy Markdown
Member

@Nking92 - perfect thanks! Merging now :)

@annatisch annatisch merged commit 0d57831 into Azure:master May 23, 2018
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: bundle install && rake arm:regen_all_profiles['azure_mgmt_web']
Finished with return code 127
and output:

/bin/sh: 1: bundle: not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants