add Azure Container Registry policies api and update OperationDefinition

[ankurkhemani]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3111

[AutorestCI]

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#106

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2774

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2173

[ankurkhemani]

@mnltejaswini @sajayantony @msyihchen @djyou

[ankurkhemani]

@marstr I don't understand why the CI complains when adding values to enum property. Can you please take a look?

INFO:swaggertosdk.autorest_tools:TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases

[marstr]

@lmazuel, is adding enum properties categorically breaking, or is this something to do with the way that value was added?

[marstr]

@ravbhatnagar may be able to help shed some light here too.

[ravbhatnagar]

Yes adding values to an enum is a breaking change. The reason being a strongly typed SDK will not be able to deserialize a value it doesnt understand. To avoid this, enums need to be categorized as modelAsString:true.

[ankurkhemani]

@ravbhatnagar We have set modelAsString: true for the enums.

[marstr]

Let me know when you're ready to merge

edit: @ravbhatnagar still has the WaitForARMFeedback label on this. We should still wait for his approval.

[ankurkhemani]

@ravbhatnagar Can you please review the swagger changes?

[ravbhatnagar]

Looks good!

[marstr]

Ready for me to merge, @ankurkhemani ?

[ankurkhemani]

@marstr Let's wait for the ARM manifest change to be applied .. I will let you know. Thanks!

[marstr]

Any updates here, or an estimated time-line for when these changes should be applied?

[marstr]

Closing as stale. Feel free to ping this thread to have it re-opened.

[AutorestCI]

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2176

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1405

[ankurkhemani]

@marstr Can you please re-open this PR and merge it?