Skip to content

Conversation

@PiDiBi
Copy link
Member

@PiDiBi PiDiBi commented May 16, 2018

added ftpsState enum to SiteConfig object

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

added ftpsState enum to SiteConfig object
@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2612

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1857

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#4

@annatisch
Copy link
Member

@PiDiBi - there is a linter error (TrackedResourcePatchOperation) for this service as well as lots of missing examples. Are you able to take a look?

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/379898643

@PiDiBi
Copy link
Member Author

PiDiBi commented May 17, 2018

@annatisch I don't see any error related to ftpsState which I added, but it's possible that I don't understand the log, I don't know what is linter

@annatisch
Copy link
Member

@PiDiBi - that's correct - the errors appear to be unrelated to this specific change.

However the TrackedResourcePatchOperation is an ARM violation for this spec and sooner or later it either needs to be resolved or suppressed. Could you please contact @ravbhatnagar in order to get a suppression approved for this error? It would be great if we could get this cleaned up in the CI.

Additionally we would love to see the examples added, though I appreciate that you may not be in a position to do so for this PR.

@naveedaz
Copy link
Contributor

@annatisch The issues pointed out in the PR are not related to change. There is a separate thread about suppressing/resolving the trackedResourcePatchOperation issue and missing examples will be handled by the documentation team. @ravbhatnagar is aware of both of these issues. This PR should not be blocked on them.

@annatisch
Copy link
Member

@naveedaz - great thanks for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants