-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Update CommonDefinitions.json #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added ftpsState enum to SiteConfig object
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
@PiDiBi - there is a linter error (TrackedResourcePatchOperation) for this service as well as lots of missing examples. Are you able to take a look? https://travis-ci.org/Azure/azure-rest-api-specs/jobs/379898643 |
|
@annatisch I don't see any error related to ftpsState which I added, but it's possible that I don't understand the log, I don't know what is linter |
|
@PiDiBi - that's correct - the errors appear to be unrelated to this specific change. However the TrackedResourcePatchOperation is an ARM violation for this spec and sooner or later it either needs to be resolved or suppressed. Could you please contact @ravbhatnagar in order to get a suppression approved for this error? It would be great if we could get this cleaned up in the CI. Additionally we would love to see the examples added, though I appreciate that you may not be in a position to do so for this PR. |
|
@annatisch The issues pointed out in the PR are not related to change. There is a separate thread about suppressing/resolving the trackedResourcePatchOperation issue and missing examples will be handled by the documentation team. @ravbhatnagar is aware of both of these issues. This PR should not be blocked on them. |
|
@naveedaz - great thanks for the context! |
Remove dash in Account and Instance
added ftpsState enum to SiteConfig object
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger