Skip to content

Conversation

@AlexanderYukhanov
Copy link
Contributor

@AlexanderYukhanov AlexanderYukhanov commented May 16, 2018

We cannot have API to list clusters and fileservers on subscription/resource group level
because of conflict with the previous API version.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

We cannot have API to list clusters and fileservers on subscription/resource group level
because of conflict with the previous API version.
@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2773

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#89

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2809

@AutorestCI
Copy link

AutorestCI commented May 16, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2065

@anuchandy
Copy link
Member

anuchandy commented May 17, 2018

@AlexanderYukhanov sorry i'm bit lost here, so we are removing some operations from api-version2018-05-01.

In the previous api version 2018-03-01 - I can see these removed operations along with other operations exists in 2018-05-01 swagger.

Why we are saying these removed operations conflicts with previous api version while other operations doesn't?

Why we are removing the required standard operations [list by RG, Subscription] on ARM resources?

@AlexanderYukhanov
Copy link
Contributor Author

Hi, Clusters and Fileservers in 2018-03-01 are TOP level resources. In 2018-05-01 the Cluster and Fileservers are CHILD resources of Workspace.
So, now we cannot list Clusters and Fileservers on subscription and RG level because there are still old Clusters and Fileservers there. We will add deleted operations later when all resources created with old API are drained.
As we understand, list by RG and Subscription are not required for child resources. Is it correct?

@anuchandy
Copy link
Member

@AlexanderYukhanov thank you clarifying, Yes, you are right, list by RG + Subscription are not a requirement for child resources. I was looking at the old api version where these resources are top level.

I see FileServers_ListByWorkspace and Clusters_ListByWorkspace, so we are supporting required child list operation in parent resource scope.

Given we already published SDKs for 2018-05-01 with these obsolete methods, what will we return if customer try to use those methods? are they NOP until the old resources are drained?

@AlexanderYukhanov
Copy link
Contributor Author

The 2018-05-01 was merged by mistake. We are still working on the API and never released SDKs for it and never updated the production for this version. So, from our side, it's API is still in work.

@anuchandy
Copy link
Member

@AlexanderYukhanov thanks for the info. Just sync-ed with @lenala and learned that there are more changes coming. Please feel free to update this PR with new changes. Inorder to merge a swagger to public repo, it is required that service is in production. Hence i'm updating the title of this PR.

Do you have some rough time frame when new service will be published to production? (if so we can add that info as well in the title)

@anuchandy anuchandy changed the title BatchAI. Remove API for list clusters and fileservers [Don't Merge] BatchAI. Remove API for list clusters and fileservers May 18, 2018
@AlexanderYukhanov
Copy link
Contributor Author

it should go into prod by the end of the month

@anuchandy anuchandy changed the title [Don't Merge] BatchAI. Remove API for list clusters and fileservers [Don't Merge, service deployment scheduled for ~May-30] BatchAI. Remove API for list clusters and fileservers May 18, 2018
@anuchandy
Copy link
Member

@AlexanderYukhanov thanks updated the title.

AlexanderYukhanov added 2 commits May 23, 2018 11:08
1. Added patch for workspace
2. Added a way to control /dev/shm for container jobs
3. Made Cluster and FileServer be proxy resources
@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AlexanderYukhanov added 2 commits May 31, 2018 01:24
1. Job priority attribute must have same name in JobProperties and JobBaseProperties
2. Added missing Caffe2Settings
@anuchandy
Copy link
Member

@AlexanderYukhanov seems you are working on the spec, just ping me when you want to take this PR

@AlexanderYukhanov
Copy link
Contributor Author

Hi @anuchandy, we finished with the spec. Today we are rolling out the API to prod and on Monday we are making API available to everybody.
So, can you please take a look at PR to be sure we will merge it ASAP after making API open?

@anuchandy
Copy link
Member

@AlexanderYukhanov sure, will take another look today.

@anuchandy anuchandy changed the title [Don't Merge, service deployment scheduled for ~May-30] BatchAI. Remove API for list clusters and fileservers [Don't Merge, service deployment scheduled for ~June-04] BatchAI. Remove API for list clusters and fileservers Jun 5, 2018
@AlexanderYukhanov
Copy link
Contributor Author

Hello, @anuchandy. We want to merge it in on Monday. Do you have any open issues or questions?

@AlexanderYukhanov
Copy link
Contributor Author

will keep it for several days. the api in production is currently under feature switch

@anuchandy anuchandy changed the title [Don't Merge, service deployment scheduled for ~June-04] BatchAI. Remove API for list clusters and fileservers [Service deployed in prod with feature flag, waiting to be public] BatchAI. Remove API for list clusters and fileservers Jun 12, 2018
@anuchandy
Copy link
Member

anuchandy commented Jun 12, 2018

@AlexanderYukhanov just sync-ed with team, the service needs to be publicly available (without feature flag) in-order to merge the spec. The reasoning behind it would be that a generated SDK would not work unless the service is available to customers. I've updated the title.

Otherwise the spec looks good. We can merge as soon as it meet above criteria.

@AlexanderYukhanov AlexanderYukhanov changed the title [Service deployed in prod with feature flag, waiting to be public] BatchAI. Remove API for list clusters and fileservers BatchAI. Remove API for list clusters and fileservers Jun 18, 2018
@AlexanderYukhanov
Copy link
Contributor Author

@anuchandy, we have removed feature switch from the production and updated the titles and descriptions in the swagger, please merge

@anuchandy anuchandy merged commit 6b5a8de into Azure:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants