-
Notifications
You must be signed in to change notification settings - Fork 5.6k
BatchAI. Remove API for list clusters and fileservers #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We cannot have API to list clusters and fileservers on subscription/resource group level because of conflict with the previous API version.
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
@AlexanderYukhanov sorry i'm bit lost here, so we are removing some operations from api-version In the previous api version Why we are saying these removed operations conflicts with previous api version while other operations doesn't? Why we are removing the required standard operations [list by RG, Subscription] on ARM resources? |
|
Hi, Clusters and Fileservers in 2018-03-01 are TOP level resources. In 2018-05-01 the Cluster and Fileservers are CHILD resources of Workspace. |
|
@AlexanderYukhanov thank you clarifying, Yes, you are right, list by RG + Subscription are not a requirement for child resources. I was looking at the old api version where these resources are top level. I see Given we already published SDKs for |
|
The 2018-05-01 was merged by mistake. We are still working on the API and never released SDKs for it and never updated the production for this version. So, from our side, it's API is still in work. |
|
@AlexanderYukhanov thanks for the info. Just sync-ed with @lenala and learned that there are more changes coming. Please feel free to update this PR with new changes. Inorder to merge a swagger to public repo, it is required that service is in production. Hence i'm updating the title of this PR. Do you have some rough time frame when new service will be published to production? (if so we can add that info as well in the title) |
|
it should go into prod by the end of the month |
|
@AlexanderYukhanov thanks updated the title. |
1. Added patch for workspace 2. Added a way to control /dev/shm for container jobs 3. Made Cluster and FileServer be proxy resources
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
1. Job priority attribute must have same name in JobProperties and JobBaseProperties 2. Added missing Caffe2Settings
|
@AlexanderYukhanov seems you are working on the spec, just ping me when you want to take this PR |
|
Hi @anuchandy, we finished with the spec. Today we are rolling out the API to prod and on Monday we are making API available to everybody. |
|
@AlexanderYukhanov sure, will take another look today. |
|
Hello, @anuchandy. We want to merge it in on Monday. Do you have any open issues or questions? |
|
will keep it for several days. the api in production is currently under feature switch |
|
@AlexanderYukhanov just sync-ed with team, the service needs to be publicly available (without feature flag) in-order to merge the spec. The reasoning behind it would be that a generated SDK would not work unless the service is available to customers. I've updated the title. Otherwise the spec looks good. We can merge as soon as it meet above criteria. |
|
@anuchandy, we have removed feature switch from the production and updated the titles and descriptions in the swagger, please merge |
We cannot have API to list clusters and fileservers on subscription/resource group level
because of conflict with the previous API version.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger