Skip to content

Add Identity to session pool registry #30748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jijohn14 merged 4 commits into from
Sep 27, 2024
Merged

Add Identity to session pool registry #30748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bec576b
Add Identity to session pool registry
najian Sep 26, 2024
c35f075
update examples
najian Sep 26, 2024
8e84f83
fix
najian Sep 26, 2024
f661d35
Merge branch 'release-app-Microsoft.App-2024-08-02-preview' into naji…
najian Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/SessionPools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@
"description": "Session pool private registry credentials.",
"type": "object",
"properties": {
"registryServer": {
"server": {
"description": "Container registry server.",
"type": "string"
},
Expand All @@ -415,6 +415,10 @@
"passwordSecretRef": {
"description": "The name of the secret that contains the registry login password",
"type": "string"
},
"identity": {
"description": "A Managed Identity to use to authenticate with Azure Container Registry. For user-assigned identities, use the full user-assigned identity Resource ID. For system-assigned identities, use 'system'",
"type": "string"
}
}
},
Expand Down
8 changes: 8 additions & 0 deletions ...anager/Microsoft.App/preview/2024-08-02-preview/examples/SessionPools_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@
],
"ingress": {
"targetPort": 80
},
"registryCredentials": {
"server": "test.azurecr.io",
"identity": "/subscriptions/7a497526-bb8d-4816-9795-db1418a1f977/resourcegroups/test/providers/Microsoft.ManagedIdentity/userAssignedIdentities/testSP"
}
},
"sessionNetworkConfiguration": {
Expand Down Expand Up @@ -137,6 +141,10 @@
],
"ingress": {
"targetPort": 80
},
"registryCredentials": {
"server": "test.azurecr.io",
"identity": "/subscriptions/7a497526-bb8d-4816-9795-db1418a1f977/resourcegroups/test/providers/Microsoft.ManagedIdentity/userAssignedIdentities/testSP"
}
},
"sessionNetworkConfiguration": {
Expand Down
4 changes: 4 additions & 0 deletions .../resource-manager/Microsoft.App/preview/2024-08-02-preview/examples/SessionPools_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@
],
"ingress": {
"targetPort": 80
},
"registryCredentials": {
"server": "test.azurecr.io",
"identity": "/subscriptions/7a497526-bb8d-4816-9795-db1418a1f977/resourcegroups/test/providers/Microsoft.ManagedIdentity/userAssignedIdentities/testSP"
}
},
"sessionNetworkConfiguration": {
Expand Down