Microsoft.ContainerInstance : Updated API version 2024-05-01-preview for ContainerGroupProfile feature by drishtipeshwani09 · Pull Request #30694 · Azure/azure-rest-api-specs

drishtipeshwani09 · 2024-09-23T18:16:41Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

… profile and the corresponding examples

openapi-pipeline-app · 2024-09-23T18:16:45Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-09-23T18:16:46Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerinstance/armcontainerinstance	https://apiview.dev/Assemblies/Review/94480d0264ec4820b781f6275cf6a7a8?revisionId=8461a77f22644bf2b161e6192e10753d
Java	azure-resourcemanager-containerinstance-generated	https://apiview.dev/Assemblies/Review/e709fb4537c54c90a1f2c1e18ba101ab?revisionId=6913421768a94b8d886ba4b1ea841000
.Net	Azure.ResourceManager.ContainerInstance	There is no API change compared with the previous version
Swagger	Microsoft.ContainerInstance	https://apiview.dev/Assemblies/Review/57ed6af1fd4140b5b89c9b62c962949f?revisionId=c1854d34140e4e708deeb8928e0bc7cb

… name and removed LRO tag

…rishtipeshwani09/azure-rest-api-specs into dpeshwani/cgProfiletolatestAPI

…or cg profile revisions

…tainer group profile name

…rishtipeshwani09/azure-rest-api-specs into dpeshwani/cgProfiletolatestAPI

azure-pipelines · 2024-09-25T09:17:02Z

Azure Pipelines successfully started running 3 pipeline(s).

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json

ms-bogdan-rotaru · 2024-09-25T12:44:10Z

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json

+          },
+          {
+            "$ref": "#/parameters/ResourceGroupNameParameter"
+          }


Same as above. #Resolved

Thank you for the suggestion!! I have replaced all the standard parameter references (SubId, ResourceGroupName, ApiVersion, Location) to directly use the one's present in common-types

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json

…irectly from the common-types

drishtipeshwani09 · 2024-09-26T06:49:23Z

/azp run

azure-pipelines · 2024-09-26T06:49:40Z

Azure Pipelines successfully started running 3 pipeline(s).

ms-bogdan-rotaru · 2024-09-26T09:02:13Z

Your branch is out-of-date with base branch, please merge with base branch before requesting merge.

…for ContainerGroupProfile feature (#30694) * Added the container group profile model , api paths related to the cg profile and the corresponding examples * Modifed cg profile properties struction, added pattern for cg profile name and removed LRO tag * Modified files names for better context and removed deregister path for cg profile revisions * Updated container group profiles patch path and added pattern for container group profile name * Updated the file name * Replaced all the standard parameter references in order to use them directly from the common-types * Corrected the relative path * Updated the sub id parameter to a uuid format

Added the container group profile model , api paths related to the cg…

bee2c01

… profile and the corresponding examples

Merge branch 'main' into dpeshwani/cgProfiletolatestAPI

0f6881f

microsoft-github-policy-service bot added the Container Instances label Sep 23, 2024

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 23, 2024

drishtipeshwani09 added 2 commits September 24, 2024 00:25

Modifed cg profile properties struction, added pattern for cg profile…

5aa1bb4

… name and removed LRO tag

Merge branch 'dpeshwani/cgProfiletolatestAPI' of https://github.com/d…

5bc9d65

…rishtipeshwani09/azure-rest-api-specs into dpeshwani/cgProfiletolatestAPI

AzureRestAPISpecReview added NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 23, 2024

Modified files names for better context and removed deregister path f…

c367a53

…or cg profile revisions

drishtipeshwani09 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 24, 2024

Merge branch 'main' into dpeshwani/cgProfiletolatestAPI

88cd85c

kaushik-ms approved these changes Sep 24, 2024

View reviewed changes

JeffreyRichter added the Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 24, 2024

drishtipeshwani09 and others added 5 commits September 25, 2024 14:05

Updated container group profiles patch path and added pattern for con…

0441514

…tainer group profile name

Merge branch 'dpeshwani/cgProfiletolatestAPI' of https://github.com/d…

7544b03

…rishtipeshwani09/azure-rest-api-specs into dpeshwani/cgProfiletolatestAPI

Merge branch 'main' into dpeshwani/cgProfiletolatestAPI

a4066e1

Updated the file name

b4208b4

Merge branch 'dpeshwani/cgProfiletolatestAPI' of https://github.com/d…

2d68e85

…rishtipeshwani09/azure-rest-api-specs into dpeshwani/cgProfiletolatestAPI

AzureRestAPISpecReview removed the NotReadyForARMReview label Sep 25, 2024

AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 25, 2024

ms-bogdan-rotaru reviewed Sep 25, 2024

View reviewed changes

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json Show resolved Hide resolved

ms-bogdan-rotaru reviewed Sep 25, 2024

View reviewed changes

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json Show resolved Hide resolved

ms-bogdan-rotaru added the ARMChangesRequested label Sep 25, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2024

drishtipeshwani09 added 2 commits September 25, 2024 19:34

Replaced all the standard parameter references in order to use them d…

8f940c0

…irectly from the common-types

Corrected the relative path

e8b9220

AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 25, 2024

drishtipeshwani09 and others added 2 commits September 25, 2024 20:03

Updated the sub id parameter to a uuid format

480c1e7

Merge branch 'main' into dpeshwani/cgProfiletolatestAPI

555d0d9

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 25, 2024

drishtipeshwani09 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2024

AzureRestAPISpecReview removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2024

drishtipeshwani09 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2024

ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 26, 2024

openapi-pipeline-app bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2024

ms-bogdan-rotaru removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2024

Merge branch 'main' into dpeshwani/cgProfiletolatestAPI

ef0c9db

ms-bogdan-rotaru approved these changes Sep 26, 2024

View reviewed changes

drishtipeshwani09 merged commit ff7d667 into Azure:main Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.ContainerInstance : Updated API version 2024-05-01-preview for ContainerGroupProfile feature#30694

Microsoft.ContainerInstance : Updated API version 2024-05-01-preview for ContainerGroupProfile feature#30694
drishtipeshwani09 merged 16 commits intoAzure:mainfrom
drishtipeshwani09:dpeshwani/cgProfiletolatestAPI

drishtipeshwani09 commented Sep 23, 2024

Uh oh!

openapi-pipeline-app bot commented Sep 23, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 23, 2024 •

edited

Loading

Uh oh!

azure-pipelines bot commented Sep 25, 2024

Uh oh!

Uh oh!

ms-bogdan-rotaru Sep 25, 2024 •

edited

Loading

Uh oh!

drishtipeshwani09 Sep 25, 2024

Uh oh!

Uh oh!

drishtipeshwani09 commented Sep 26, 2024

Uh oh!

azure-pipelines bot commented Sep 26, 2024

Uh oh!

ms-bogdan-rotaru commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

drishtipeshwani09 commented Sep 23, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

azure-pipelines bot commented Sep 25, 2024

Uh oh!

Uh oh!

ms-bogdan-rotaru Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drishtipeshwani09 Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

drishtipeshwani09 commented Sep 26, 2024

Uh oh!

azure-pipelines bot commented Sep 26, 2024

Uh oh!

ms-bogdan-rotaru commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app bot commented Sep 23, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 23, 2024 •

edited

Loading

ms-bogdan-rotaru Sep 25, 2024 •

edited

Loading