Skip to content

Appended "update" @visibility to BaseResourceProperties::marketplace field#30626

Merged
ms-bogdan-rotaru merged 4 commits intoAzure:mainfrom
vikaschoudharycs097:configurable-auto-renew-feature
Sep 25, 2024
Merged

Appended "update" @visibility to BaseResourceProperties::marketplace field#30626
ms-bogdan-rotaru merged 4 commits intoAzure:mainfrom
vikaschoudharycs097:configurable-auto-renew-feature

Conversation

@vikaschoudharycs097
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • Extending Organization_Update operation for "edit recurring billing" feature. As we need to change @visibility of BaseResourceProperties::marketplace field, we can't control changes for existing API versions.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[Reason]
-----------------
- For recurring billing patch operation, appended "update" @visibility
  to BaseResourceProperties::marketplace
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 18, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 18, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 18, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 18, 2024
@mikekistler mikekistler added the Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 23, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 23, 2024
@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 24, 2024
@banggaurav banggaurav added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 24, 2024
@vikaschoudharycs097
Copy link
Contributor Author

/pr RequestMerge

1 similar comment
@ms-bogdan-rotaru
Copy link
Contributor

/pr RequestMerge

@ms-bogdan-rotaru
Copy link
Contributor

As requested offline, this PR is ready for merge. Adding the label.

@ms-bogdan-rotaru ms-bogdan-rotaru merged commit befbed4 into Azure:main Sep 25, 2024
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
…field (#30626)

* Appended "update" @visibility to marketplace field

[Reason]
-----------------
- For recurring billing patch operation, appended "update" @visibility
  to BaseResourceProperties::marketplace

* Fixing "Swagger PrettierCheck" and "TypeSpec Validation" issues

* Fixing swagger check issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants