Skip to content

[SCVMM] Make the request body optional for VirtualMachineInstances/Stop #30401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajaygit158 merged 5 commits into from
Oct 3, 2024
Merged

[SCVMM] Make the request body optional for VirtualMachineInstances/Stop #30401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e8f93e
Make the stop machine request body optional
sidsinghms Sep 2, 2024
0b09df5
[tsp compile] Update scvmm.json for 2023-10-07
sidsinghms Sep 2, 2024
08b14ee
[tsp compile] Update scvmm.json for 2024-06-01
sidsinghms Sep 2, 2024
fcc824c
Create sdk-suppressions.yaml
kazrael2119 Sep 12, 2024
34f160b
Merge branch 'main' into main
sidsinghms Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion specification/scvmm/ScVmm.Management/VirtualMachineInstance.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ interface VirtualMachineInstances {
@summary("Implements the operation to stop a virtual machine.")
stop is ArmResourceActionNoResponseContentAsync<
VirtualMachineInstance,
StopVirtualMachineOptions
{
/** The content of the action request */
@body
body?: StopVirtualMachineOptions;
}
>;
/** The operation to start a virtual machine instance. */
@summary("Implements the operation to start a virtual machine.")
Expand Down
2 changes: 1 addition & 1 deletion specification/scvmm/resource-manager/Microsoft.ScVmm/stable/2023-10-07/scvmm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@
"name": "body",
"in": "body",
"description": "The content of the action request",
"required": true,
"required": false,
"schema": {
"$ref": "#/definitions/StopVirtualMachineOptions"
}
Expand Down
2 changes: 1 addition & 1 deletion specification/scvmm/resource-manager/Microsoft.ScVmm/stable/2024-06-01/scvmm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@
"name": "body",
"in": "body",
"description": "The content of the action request",
"required": true,
"required": false,
"schema": {
"$ref": "#/definitions/StopVirtualMachineOptions"
}
Expand Down
6 changes: 6 additions & 0 deletions specification/scvmm/resource-manager/sdk-suppressions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
suppressions:
azure-sdk-for-js:
- package: "@azure/arm-scvmm"
breaking-changes:
- Operation VirtualMachineInstances.beginStop has a new signature
- Operation VirtualMachineInstances.beginStopAndWait has a new signature