Skip to content

Watchlist fix lint failures #30191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuhumsft merged 6 commits into from
Aug 15, 2024
Merged

Watchlist fix lint failures #30191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb36d68
Watchlist fix lint failures
nbatyrbb Aug 13, 2024
142a5b0
fix lint
nbatyrbb Aug 14, 2024
b5007e3
lint
nbatyrbb Aug 14, 2024
dff4e37
provisioning states
nbatyrbb Aug 14, 2024
b3d7dda
lint again
nbatyrbb Aug 14, 2024
688f422
model validation
nbatyrbb Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions ...ts/resource-manager/Microsoft.SecurityInsights/preview/2024-04-01-preview/Watchlists.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,15 @@
}
],
"responses": {
"200": {
"202": {
"description": "OK",
"headers": {
"Azure-AsyncOperation": {
"description": "Contains the status URL on which clients are expected to poll the status of the delete operation.",
"type": "string"
},
"Location": {
"type": "string"
}
}
},
Expand All @@ -170,10 +173,11 @@
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "../../../common/2.0/types.json#/definitions/CloudError"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
}
},
"x-ms-long-running-operation": true
},
"put": {
"x-ms-examples": {
Expand Down Expand Up @@ -231,10 +235,11 @@
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "../../../common/2.0/types.json#/definitions/CloudError"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
}
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/watchlists/{watchlistAlias}/watchlistItems": {
Expand Down Expand Up @@ -579,6 +584,9 @@
"uploadStatus": {
"description": "The status of the Watchlist upload : New, InProgress or Complete. Pls note : When a Watchlist upload status is equal to InProgress, the Watchlist cannot be deleted",
"type": "string"
},
"provisioningState": {
"$ref": "#/definitions/ProvisioningState"
}
},
"required": [
Expand Down Expand Up @@ -665,19 +673,31 @@
},
"itemsKeyValue": {
"description": "key-value pairs for a watchlist item",
"type": "object",
"additionalProperties": {}
"type": "object"
},
"entityMapping": {
"description": "key-value pairs for a watchlist item entity mapping",
"type": "object",
"additionalProperties": {}
"type": "object"
}
},
"required": [
"itemsKeyValue"
],
"type": "object"
},
"ProvisioningState": {
"description": "Describes provisioning state",
"enum": [
"Succeeded",
"Failed",
"Canceled"
],
"type": "string",
"x-ms-enum": {
"name": "ProvisioningState",
"modelAsString": true
},
"readOnly": true
}
},
"parameters": {
Expand Down
2 changes: 1 addition & 1 deletion ...soft.SecurityInsights/preview/2024-04-01-preview/examples/watchlists/DeleteWatchlist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"watchlistAlias": "highValueAsset"
},
"responses": {
"200": {
"202": {
"headers": {
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.SecurityInsights/watchlists/1011-01/watchlistStatuses/00000000-0000-0000-0000-000000000000?api-version=2024-04-01-preview"
}
Expand Down