Skip to content

Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs #30154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jijohn14 merged 7 commits into from
Aug 21, 2024
Merged

Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs #30154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8d1fc93
Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_Event…
tawalke Aug 9, 2024
a06df03
PR Feedback: Run prettier on json file for PR check-TEW
tawalke Aug 12, 2024
c23a4cf
PR Feedback: Update ARM for Container Apps with both cooldown and pol…
tawalke Aug 12, 2024
d3a73a2
PR Feedback: Update ContainerApp examples with KEDA properties cooldo…
tawalke Aug 12, 2024
fa31c4b
PR Feedback: Re-ran prettier on files noted in PR Check-TEW
tawalke Aug 12, 2024
9bdbc2e
Removing cooldownPeriod from Jobs.json and Jobs examples-TEW
tawalke Aug 13, 2024
51081b8
Merge branch 'release-app-Microsoft.App-2024-08-02-preview' into tawa…
tawalke Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...tion/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,18 @@
"type": "integer",
"default": 10
},
"cooldownPeriod": {
"format": "int32",
"description": "Optional. KEDA Cooldown Period. Defaults to 300 seconds if not set.",
"type": "integer",
"default": 300
},
"pollingInterval": {
"format": "int32",
"description": "Optional. KEDA Polling Interval. Defaults to 30 seconds if not set.",
"type": "integer",
"default": 30
},
"rules": {
"description": "Scaling rules.",
"type": "array",
Expand Down Expand Up @@ -2171,4 +2183,3 @@
}
]
}

1 change: 0 additions & 1 deletion specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/Jobs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,4 +1283,3 @@
}
]
}

7 changes: 6 additions & 1 deletion ...nager/Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -415,6 +417,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -601,6 +605,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -652,4 +658,3 @@
}
}
}

7 changes: 6 additions & 1 deletion ...review/2024-08-02-preview/examples/ContainerApps_CreateOrUpdate_ConnectedEnvironment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -314,6 +316,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -438,6 +442,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand All @@ -456,4 +462,3 @@
}
}
}

3 changes: 2 additions & 1 deletion ...resource-manager/Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -210,4 +212,3 @@
"404": {}
}
}

9 changes: 7 additions & 2 deletions .../Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_Kind_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
],
"scale": {
"minReplicas": 1,
"maxReplicas": 30
"maxReplicas": 30,
"cooldownPeriod": 350,
"pollingInterval": 35
}
}
}
Expand Down Expand Up @@ -103,6 +105,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 30,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": null
},
"volumes": null,
Expand Down Expand Up @@ -180,6 +184,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 30,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": null
},
"volumes": null,
Expand All @@ -194,4 +200,3 @@
}
}
}

6 changes: 5 additions & 1 deletion .../Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -182,7 +184,9 @@
],
"scale": {
"minReplicas": 1,
"maxReplicas": 5
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35
}
},
"eventStreamEndpoint": "testEndpoint"
Expand Down
3 changes: 2 additions & 1 deletion ...r/Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -155,4 +157,3 @@
}
}
}

7 changes: 6 additions & 1 deletion ...osoft.App/preview/2024-08-02-preview/examples/ContainerApps_ManagedBy_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "tcpscalingrule",
Expand Down Expand Up @@ -115,6 +117,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "tcpscalingrule",
Expand Down Expand Up @@ -185,6 +189,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "tcpscalingrule",
Expand All @@ -202,4 +208,3 @@
}
}
}

5 changes: 4 additions & 1 deletion ...source-manager/Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_Patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -261,6 +263,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand All @@ -284,4 +288,3 @@
}
}
}

3 changes: 2 additions & 1 deletion ...pp/preview/2024-08-02-preview/examples/ContainerApps_SourceToCloudApp_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand Down Expand Up @@ -488,4 +490,3 @@
}
}
}

3 changes: 2 additions & 1 deletion ...source-manager/Microsoft.App/preview/2024-08-02-preview/examples/ContainerApps_Start.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "httpscalingrule",
Expand All @@ -141,4 +143,3 @@
}
}
}

7 changes: 6 additions & 1 deletion ...icrosoft.App/preview/2024-08-02-preview/examples/ContainerApps_TcpApp_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "tcpscalingrule",
Expand Down Expand Up @@ -113,6 +115,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "tcpscalingrule",
Expand Down Expand Up @@ -182,6 +186,8 @@
"scale": {
"minReplicas": 1,
"maxReplicas": 5,
"cooldownPeriod": 350,
"pollingInterval": 35,
"rules": [
{
"name": "tcpscalingrule",
Expand All @@ -199,4 +205,3 @@
}
}
}

1 change: 0 additions & 1 deletion ...er/Microsoft.App/preview/2024-08-02-preview/examples/Job_CreateorUpdate_EventTrigger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,3 @@
}
}
}