Skip to content

Add GetOperationsError endpoint to Computeschedule #30120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NneOkeke wants to merge 4 commits into from
Closed

Add GetOperationsError endpoint to Computeschedule #30120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
459c9c1
initial commit to add endpoint
NneOkeke Aug 8, 2024
4be3863
added new endpoint to computeschedule
NneOkeke Aug 8, 2024
2aab694
added new version
NneOkeke Aug 8, 2024
be9fb45
Merge branch 'add-geterror-endpoint' of https://github.com/NneOkeke/a…
NneOkeke Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...eview/Operations_List_MaximumSet_Gen.json → ...eview/Operations_List_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "Operations_ListMax - generated by [MaximumSet] rule",
"operationId": "Operations_List",
"parameters": {
"api-version": "2024-06-01-preview"
"api-version": "2024-08-01-preview"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...eview/Operations_List_MinimumSet_Gen.json → ...eview/Operations_List_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "Operations_ListMax - generated by [MinimumSet] rule",
"operationId": "Operations_List",
"parameters": {
"api-version": "2024-06-01-preview"
"api-version": "2024-08-01-preview"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...hinesCancelOperations_MaximumSet_Gen.json → ...hinesCancelOperations_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesCancelOperations - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesCancelOperations",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "juzzyocyywfxwakqmgahb",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...hinesCancelOperations_MinimumSet_Gen.json → ...hinesCancelOperations_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesCancelOperations - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesCancelOperations",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "lzrfledwkzrp",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...inesExecuteDeallocate_MaximumSet_Gen.json → ...inesExecuteDeallocate_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesExecuteDeallocate - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesExecuteDeallocate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "dspazcfydfdhxer",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...inesExecuteDeallocate_MinimumSet_Gen.json → ...inesExecuteDeallocate_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesExecuteDeallocate - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesExecuteDeallocate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "zanmxbtvfqzqqtywqtnslqxfk",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...hinesExecuteHibernate_MaximumSet_Gen.json → ...hinesExecuteHibernate_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesExecuteHibernate - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesExecuteHibernate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "az",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...hinesExecuteHibernate_MinimumSet_Gen.json → ...hinesExecuteHibernate_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesExecuteHibernate - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesExecuteHibernate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "oowpasegipasucmq",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...lMachinesExecuteStart_MaximumSet_Gen.json → ...lMachinesExecuteStart_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesExecuteStart - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesExecuteStart",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "cwkjesffxrcxaxbnvqumkjbbymwlpe",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...lMachinesExecuteStart_MinimumSet_Gen.json → ...lMachinesExecuteStart_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesExecuteStart - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesExecuteStart",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "puguskuewwqfrdkmwrnzb",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...nesGetOperationStatus_MaximumSet_Gen.json → ...nesGetOperationStatus_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesGetOperationStatus - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesGetOperationStatus",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "lfmx",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...nesGetOperationStatus_MinimumSet_Gen.json → ...nesGetOperationStatus_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesGetOperationStatus - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesGetOperationStatus",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "csay",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...hinesSubmitDeallocate_MaximumSet_Gen.json → ...hinesSubmitDeallocate_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesSubmitDeallocate - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesSubmitDeallocate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "nynqafujbcjyrtqve",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...hinesSubmitDeallocate_MinimumSet_Gen.json → ...hinesSubmitDeallocate_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesSubmitDeallocate - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesSubmitDeallocate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "gfuns",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...chinesSubmitHibernate_MaximumSet_Gen.json → ...chinesSubmitHibernate_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesSubmitHibernate - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesSubmitHibernate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "jrulwh",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...chinesSubmitHibernate_MinimumSet_Gen.json → ...chinesSubmitHibernate_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesSubmitHibernate - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesSubmitHibernate",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "pgedjeucp",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...alMachinesSubmitStart_MaximumSet_Gen.json → ...alMachinesSubmitStart_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesSubmitStart - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesSubmitStart",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "pxbvjarpyzhastophdyu",
"requestBody": {
Expand Down
2 changes: 1 addition & 1 deletion ...alMachinesSubmitStart_MinimumSet_Gen.json → ...alMachinesSubmitStart_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"title": "ScheduledActions_VirtualMachinesSubmitStart - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMachinesSubmitStart",
"parameters": {
"api-version": "2024-06-01-preview",
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "vkrnfmvxrtbzgeyqmhtney",
"requestBody": {
Expand Down
37 changes: 37 additions & 0 deletions ...2024-08-01-preview/ScheduledActions_VirtualMahcinesGetOperationErrors_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"title": "ScheduledActions_VirtualMahcinesGetOperationErrors - generated by [MaximumSet] rule - generated by [MaximumSet] rule",
"operationId": "ScheduledActions_VirtualMahcinesGetOperationErrors",
"parameters": {
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "tbwsdkgvzmbxsjxqdlcztpgfav",
"requestBody": {
"operationIds": [
"23230d2f-1dca-4610-afb4-dd25eec1f3d"
]
}
},
"responses": {
"200": {
"body": {
"results": [
{
"operationId": "23230d2f-1dca-4610-afb4-dd25eec1f3d",
"creationTime": "2024-08-08T14:23:07.053Z",
"activationTime": "2024-08-08T14:23:07.053Z",
"completedAt": "2024-08-08T14:23:07.053Z",
"operationErrors": [
{
"errorCode": "flenwtmjdfbhguc",
"errorDetails": "2024-08-08T14:23:07.053Z",
"timeStamp": "2024-08-08T14:23:07.053Z"
}
],
"requestErrorCode": "qrfvqjtfldjqrma",
"requestErrorDetails": "tbxyvztbkjmvrytvb"
}
]
}
}
}
}
26 changes: 26 additions & 0 deletions ...2024-08-01-preview/ScheduledActions_VirtualMahcinesGetOperationErrors_MinimumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"title": "ScheduledActions_VirtualMahcinesGetOperationErrors - generated by [MaximumSet] rule - generated by [MinimumSet] rule",
"operationId": "ScheduledActions_VirtualMahcinesGetOperationErrors",
"parameters": {
"api-version": "2024-08-01-preview",
"subscriptionId": "DE84A209-5715-43E7-BC76-3E208A9A82C5",
"locationparameter": "mropewftzbfrwyaoccouvjondwx",
"requestBody": {
"operationIds": [
"23230d2f-1dca-4610-afb4-dd25eec1f3d"
]
}
},
"responses": {
"200": {
"body": {
"results": [
{
"operationId": "23230d2f-1dca-4610-afb4-dd25eec1f3d",
"creationTime": "2024-08-08T14:23:07.053Z"
}
]
}
}
}
}
4 changes: 2 additions & 2 deletions specification/computeschedule/ComputeSchedule.Management/main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ namespace Microsoft.ComputeSchedule;

/** ComputeSchedule API versions */
enum Versions {
/** 2024-06-01-preview version */
/** 2024-08-01-preview version */
@useDependency(Azure.ResourceManager.Versions.v1_0_Preview_1)
@useDependency(Azure.Core.Versions.v1_0_Preview_2)
@armCommonTypesVersion(Azure.ResourceManager.CommonTypes.Versions.v5)
`2024-06-01-preview`,
`2024-08-01-preview`,
}
54 changes: 54 additions & 0 deletions specification/computeschedule/ComputeSchedule.Management/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,46 @@ model ResourceOperation {
operation?: ResourceOperationDetails;
}

#suppress "@azure-tools/typespec-azure-core/no-offsetdatetime" "Prefer using `utcDateTime` when representing a datetime unless an offset is necessary."
@doc("This defines a list of operation errors associated with a unique operationId")
model OperationErrorDetails {
@doc("The error code of the operation")
errorCode: string;

@doc("The error details of the operation")
errorDetails: offsetDateTime;

@doc("The timestamp of the error occurence")
timeStamp: offsetDateTime;
}

#suppress "@azure-tools/typespec-azure-core/no-offsetdatetime" "Prefer using `utcDateTime` when representing a datetime unless an offset is necessary."
@doc("This is the first level of operation errors from the request to get errors per vm operation")
model OperationErrorsResult {
@doc("The operationId identifying a vm operation")
operationId: string;

@doc("The creation time of the error result")
creationTime: offsetDateTime;

@doc("The activation time of a vm operation")
activationTime?: offsetDateTime;

@doc("The completion time of the operation if the operation was completed")
completedAt?: offsetDateTime;

@extension("x-ms-identifiers", [])
@doc("A list of errors associated with the operationid")
operationErrors?: Array<OperationErrorDetails>;

@doc("Request level error code")
requestErrorCode?: string;

@doc("Request level error details")
requestErrorDetails?: string;
}


// ----------- SubmitDeallocate ---------
@doc("The deallocate request for resources")
model SubmitDeallocateRequest {
Expand Down Expand Up @@ -376,3 +416,17 @@ model CancelOperationsResponse {
@doc("An array of resource operations that were successfully cancelled")
results: Array<ResourceOperation>;
}

// ----------- GetOperationErrors ---------
@doc("This is the request to get errors per vm operations")
model GetOperationErrorsRequest {
@doc("The list of operation ids to query errors of")
operationIds: Array<string>;
}

@doc("This is the response from a get operations errors request")
model GetOperationErrorsResponse {
@extension("x-ms-identifiers", ["operationId"])
@doc("An array of operationids and their corresponding errors if any")
results: Array<OperationErrorsResult>;
}
9 changes: 9 additions & 0 deletions specification/computeschedule/ComputeSchedule.Management/routes.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,13 @@ interface ScheduledActions {
...Params,
@body @doc("The request body") requestBody: CancelOperationsRequest,
): ArmResponse<CancelOperationsResponse> | ErrorResponse;

/** virtualMachinesGetOperationErrors: getOperationErrors associated with an operation on a virtual machine */
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation" "necessary to avoid standard routing"
@route("/subscriptions/{subscriptionId}/providers/Microsoft.ComputeSchedule/locations/{locationparameter}/virtualMachinesGetOperationErrors")
@post
virtualMachinesGetOperationErrors(
...Params,
@body @doc("The request body") requestBody: GetOperationErrorsRequest,
): ArmResponse<GetOperationErrorsResponse> | ErrorResponse;
}
Loading