[Review Only] Add InVMAccessControlProfile for GalleryRP in new API version 2024-03-03#29852
[Review Only] Add InVMAccessControlProfile for GalleryRP in new API version 2024-03-03#29852lkumaar wants to merge 9 commits intoAzure:mainfrom
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
|
@microsoft-github-policy-service agree company="Microsoft" |
|
Requesting review for the APIs for new resource type to unblock manifest check in. |
...3/examples/galleryResourceProfileExamples/GalleryInVMAccessControlProfileVersion_Delete.json
Outdated
Show resolved
Hide resolved
...24-03-03/examples/galleryResourceProfileExamples/GalleryInVMAccessControlProfile_Delete.json
Outdated
Show resolved
Hide resolved
...fication/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29852 in repo Azure/azure-rest-api-specs |
| "tags": [ | ||
| "GalleryInVMAccessControlProfiles" | ||
| ], | ||
| "operationId": "GalleryInVMAccessControlProfiles_CreateOrUpdate", |
There was a problem hiding this comment.
This always confused me. Why is there a CreateOrUpdate operation, then a separate Update operation? Does the CreateOrUpdate actually do an Update? Do these operations do something different or under different circumstances?
There was a problem hiding this comment.
Does the CreateOrUpdate actually do an Update?
Yes
Do these operations do something different or under different circumstances?
No. Both operations are handled in the exact same manner in the service side. Both operations follow patch semantics, and this is the usual pattern for all our resources. I believe it's the same with other RPs in Compute.
...fication/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json
Outdated
Show resolved
Hide resolved
...fication/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2024-03-03/gallery.json
Outdated
Show resolved
Hide resolved
|
Hi, @lkumaar. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @lkumaar. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.