Skip to content

move directive to readme.md to avoid unnecessary breaking changes for… #29742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2024
Merged

move directive to readme.md to avoid unnecessary breaking changes for… #29742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1e08b8
move directive to readme.md to avoid unnecessary breaking changes for…
kazrael2119 Jul 9, 2024
867bfce
update suppressions
kazrael2119 Jul 9, 2024
3d3eed3
Merge branch 'main' into move-directive
qiaozha Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions specification/liftrqumulo/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,29 +8,4 @@ module-name: sdk/resourcemanager/liftrqumulo/armqumulo
module: github.com/Azure/azure-sdk-for-go/$(module-name)
output-folder: $(go-sdk-folder)/$(module-name)
azure-arm: true
directive:
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceUpdate'
to: FileSystemResourceUpdate
- rename-model:
from: 'LiftrBase.Storage.FileSystemResource'
to: FileSystemResource
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceUpdateProperties'
to: FileSystemResourceUpdateProperties
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceProperties'
to: FileSystemResourceProperties
- rename-model:
from: 'LiftrBase.MarketplaceDetails'
to: MarketplaceDetails
- rename-model:
from: 'LiftrBase.MarketplaceSubscriptionStatus'
to: MarketplaceSubscriptionStatus
- rename-model:
from: 'LiftrBase.UserDetails'
to: UserDetails
- rename-model:
from: 'LiftrBase.ProvisioningState'
to: ProvisioningState
```
25 changes: 25 additions & 0 deletions specification/liftrqumulo/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,31 @@ These are the global settings for the Qumulo.Storage.
openapi-type: arm
openapi-subtype: rpaas
tag: package-2024-06-19
directive:
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceUpdate'
to: FileSystemResourceUpdate
- rename-model:
from: 'LiftrBase.Storage.FileSystemResource'
to: FileSystemResource
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceUpdateProperties'
to: FileSystemResourceUpdateProperties
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceProperties'
to: FileSystemResourceProperties
- rename-model:
from: 'LiftrBase.MarketplaceDetails'
to: MarketplaceDetails
- rename-model:
from: 'LiftrBase.MarketplaceSubscriptionStatus'
to: MarketplaceSubscriptionStatus
- rename-model:
from: 'LiftrBase.UserDetails'
to: UserDetails
- rename-model:
from: 'LiftrBase.ProvisioningState'
to: ProvisioningState
```


Expand Down
26 changes: 0 additions & 26 deletions specification/liftrqumulo/resource-manager/readme.typescript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,4 @@ typescript:
output-folder: "$(typescript-sdks-folder)/sdk/liftrqumulo/arm-qumulo"
payload-flattening-threshold: 1
generate-metadata: true

directive:
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceUpdate'
to: FileSystemResourceUpdate
- rename-model:
from: 'LiftrBase.Storage.FileSystemResource'
to: FileSystemResource
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceUpdateProperties'
to: FileSystemResourceUpdateProperties
- rename-model:
from: 'LiftrBase.Storage.FileSystemResourceProperties'
to: FileSystemResourceProperties
- rename-model:
from: 'LiftrBase.MarketplaceDetails'
to: MarketplaceDetails
- rename-model:
from: 'LiftrBase.MarketplaceSubscriptionStatus'
to: MarketplaceSubscriptionStatus
- rename-model:
from: 'LiftrBase.UserDetails'
to: UserDetails
- rename-model:
from: 'LiftrBase.ProvisioningState'
to: ProvisioningState
```
7 changes: 7 additions & 0 deletions specification/liftrqumulo/resource-manager/sdk-suppressions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,10 @@ suppressions:
- Field `InitialCapacity` of struct `FileSystemResourceProperties` has been removed
- Type of `FileSystemResourceProperties.StorageSKU` has been changed from `*StorageSKU` to `*string`
- "`ProvisioningStateNotSpecified` from enum `ProvisioningState` has been removed"
azure-sdk-for-js:
- package: '@azure/arm-qumulo'
breaking-changes:
- Interface FileSystemResource no longer has parameter initialCapacity
- Interface FileSystemResourceUpdateProperties no longer has parameter clusterLoginUrl
- Interface FileSystemResourceUpdateProperties no longer has parameter privateIPs
- Type of parameter storageSku of interface FileSystemResource is changed from StorageSku to string