Added and fixed build tags for the Go SDK. by jhendrixMSFT · Pull Request #2974 · Azure/azure-rest-api-specs

jhendrixMSFT · 2018-04-30T18:15:29Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-04-30T18:15:31Z

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

machinelearning/resource-manager
batchai/resource-manager
web/resource-manager
deviceprovisioningservices/resource-manager
cognitiveservices/data-plane/VisualSearch
keyvault/data-plane
network/resource-manager
containerinstance/resource-manager
subscription/resource-manager
botservice/resource-manager
resources/resource-manager
monitor/resource-manager
containerregistry/resource-manager

AutorestCI · 2018-04-30T18:15:32Z

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

botservice/resource-manager
containerinstance/resource-manager
batchai/resource-manager
machinelearning/resource-manager
network/resource-manager
resources/resource-manager
cognitiveservices/data-plane/VisualSearch
subscription/resource-manager
keyvault/data-plane
containerregistry/resource-manager
deviceprovisioningservices/resource-manager
web/resource-manager
monitor/resource-manager

AutorestCI · 2018-04-30T18:15:34Z

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

botservice/resource-manager
cognitiveservices/data-plane/VisualSearch
containerinstance/resource-manager
keyvault/data-plane
subscription/resource-manager
batchai/resource-manager
network/resource-manager
resources/resource-manager
web/resource-manager
monitor/resource-manager
machinelearning/resource-manager
containerregistry/resource-manager
deviceprovisioningservices/resource-manager

jhendrixMSFT · 2018-04-30T18:15:51Z

Fixes Azure/azure-sdk-for-go#1425.

azuresdkciprbot · 2018-04-30T18:27:15Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/batchai/resource-manager/readme.md

⚠️

0 new Warnings.(5 total)

❌0 new Errors.(0 total)

File: specification/botservice/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/cognitiveservices/data-plane/VisualSearch/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/containerinstance/resource-manager/readme.md

⚠️

0 new Warnings.(2 total)

❌0 new Errors.(0 total)

File: specification/containerregistry/resource-manager/readme.md

⚠️

0 new Warnings.(4 total)

❌0 new Errors.(0 total)

File: specification/deviceprovisioningservices/resource-manager/readme.md

⚠️

0 new Warnings.(6 total)

❌0 new Errors.(0 total)

File: specification/keyvault/data-plane/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/machinelearning/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/monitor/resource-manager/readme.md

⚠️

0 new Warnings.(17 total)

❌0 new Errors.(0 total)

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(0 total)

File: specification/resources/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/subscription/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/web/resource-manager/readme.md

⚠️

0 new Warnings.(638 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T18:27:15Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/batchai/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/botservice/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/cognitiveservices/data-plane/VisualSearch/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/containerinstance/resource-manager/readme.md

⚠️

0 new Warnings.(2 total)

❌0 new Errors.(0 total)

File: specification/containerregistry/resource-manager/readme.md

⚠️

0 new Warnings.(7 total)

❌0 new Errors.(0 total)

File: specification/deviceprovisioningservices/resource-manager/readme.md

⚠️

0 new Warnings.(11 total)

❌0 new Errors.(0 total)

File: specification/keyvault/data-plane/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(30 total)

File: specification/machinelearning/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/monitor/resource-manager/readme.md

⚠️

0 new Warnings.(20 total)

❌0 new Errors.(1 total)

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(78 total)

File: specification/resources/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

File: specification/subscription/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(4 total)

File: specification/web/resource-manager/readme.md

⚠️

0 new Warnings.(154 total)

❌0 new Errors.(22 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

vladbarosan · 2018-04-30T18:36:16Z

specification/deviceprovisioningservices/resource-manager/readme.md

 ### Tag: package-2017-08 and go

-These settings apply only when `--tag=package-2017-11 --go` is specified on the command line.
+These settings apply only when `--tag=package-2017-08 --go` is specified on the command line.


How did you go by discovering these inconsistencies ? just checking each file ?

AutorestCI · 2018-04-30T19:57:30Z

Automation for azure-libraries-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

batchai/resource-manager
monitor/resource-manager
subscription/resource-manager
botservice/resource-manager
machinelearning/resource-manager
keyvault/data-plane
web/resource-manager
network/resource-manager
cognitiveservices/data-plane/VisualSearch
containerregistry/resource-manager
containerinstance/resource-manager
resources/resource-manager
deviceprovisioningservices/resource-manager

Added and fixed build tags for the Go SDK.

a220fbe

jhendrixMSFT self-assigned this Apr 30, 2018

jhendrixMSFT requested review from marstr and vladbarosan April 30, 2018 18:15

jhendrixMSFT requested review from DeepakRajendranMsft, MikhailTryakhov and schaabs as code owners April 30, 2018 18:15

vladbarosan reviewed Apr 30, 2018

View reviewed changes

marstr approved these changes Apr 30, 2018

View reviewed changes

jhendrixMSFT merged commit e2c256a into Azure:master Apr 30, 2018

jhendrixMSFT deleted the cfgscrub branch April 30, 2018 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added and fixed build tags for the Go SDK.#2974

Added and fixed build tags for the Go SDK.#2974
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jhendrixMSFT:cfgscrub

jhendrixMSFT commented Apr 30, 2018

Uh oh!

AutorestCI commented Apr 30, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Apr 30, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Apr 30, 2018 •

edited

Loading

Uh oh!

jhendrixMSFT commented Apr 30, 2018

Uh oh!

azuresdkciprbot commented Apr 30, 2018

Uh oh!

azuresdkciprbot commented Apr 30, 2018

Uh oh!

vladbarosan Apr 30, 2018

Uh oh!

AutorestCI commented Apr 30, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

jhendrixMSFT commented Apr 30, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Apr 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Apr 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Apr 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

jhendrixMSFT commented Apr 30, 2018

Uh oh!

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

vladbarosan Apr 30, 2018

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Apr 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading