Skip to content

Microsoft.Fabric - Fix Delete & Update Status Codes. #29721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Microsoft.Fabric - Fix Delete & Update Status Codes. #29721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e77d15
fix status codes and corresponding examples
badeamarjieh Jul 8, 2024
f2fa156
fix update exmaple
badeamarjieh Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/fabric/Microsoft.Fabric.Management/capacity.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ model FabricCapacity is TrackedResource<FabricCapacityProperties> {
interface FabricCapacities {
get is ArmResourceRead<FabricCapacity>;
createOrUpdate is ArmResourceCreateOrReplaceAsync<FabricCapacity>;
update is ArmResourcePatchSync<FabricCapacity, FabricCapacityProperties>;
delete is ArmResourceDeleteSync<FabricCapacity>;
update is ArmResourcePatchAsync<FabricCapacity, FabricCapacityProperties>;
delete is ArmResourceDeleteWithoutOkAsync<FabricCapacity>;
listByResourceGroup is ArmResourceListByParent<FabricCapacity>;
listBySubscription is ArmListBySubscription<FabricCapacity>;

Expand Down
7 changes: 6 additions & 1 deletion ...ation/fabric/Microsoft.Fabric.Management/examples/2023-11-01/FabricCapacities_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
"capacityName": "azsdktest"
},
"responses": {
"200": {},
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationresults/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-",
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationstatuses/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-"
}
},
"204": {}
}
}
10 changes: 8 additions & 2 deletions ...ation/fabric/Microsoft.Fabric.Management/examples/2023-11-01/FabricCapacities_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"200": {
"body": {
"properties": {
"provisioningState": "Provisioning",
"state": "Provisioning",
"provisioningState": "Updating",
"state": "Preparing",
"administration": {
"members": [
"[email protected]"
Expand All @@ -47,6 +47,12 @@
"name": "azsdktest",
"type": "Microsoft.Fabric/capacities"
}
},
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationresults/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-",
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationstatuses/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-"
}
}
}
}
7 changes: 6 additions & 1 deletion ...resource-manager/Microsoft.Fabric/stable/2023-11-01/examples/FabricCapacities_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
"capacityName": "azsdktest"
},
"responses": {
"200": {},
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationresults/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-",
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationstatuses/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-"
}
},
"204": {}
}
}
10 changes: 8 additions & 2 deletions ...resource-manager/Microsoft.Fabric/stable/2023-11-01/examples/FabricCapacities_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"200": {
"body": {
"properties": {
"provisioningState": "Provisioning",
"state": "Provisioning",
"provisioningState": "Updating",
"state": "Preparing",
"administration": {
"members": [
"[email protected]"
Expand All @@ -47,6 +47,12 @@
"name": "azsdktest",
"type": "Microsoft.Fabric/capacities"
}
},
"202": {
"headers": {
"Location": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationresults/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-",
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/548B7FB7-3B2A-4F46-BB02-66473F1FC22C/providers/Microsoft.Fabric/locations/westcentralus/operationstatuses/946B9C42-0D6C-4A42-94AE-1156A1EC8534?api-version=2023-11-01&t=638525901413778740&c=MIIH5zCCBs-"
}
}
}
}
41 changes: 37 additions & 4 deletions specification/fabric/resource-manager/Microsoft.Fabric/stable/2023-11-01/fabric.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,20 @@
"$ref": "#/definitions/FabricCapacity"
}
},
"202": {
"description": "Resource update request accepted.",
"headers": {
"Location": {
"type": "string",
"description": "The Location header contains the URL where the status of the long running operation can be checked."
},
"Retry-After": {
"type": "integer",
"format": "int32",
"description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
}
}
},
"default": {
"description": "An unexpected error response.",
"schema": {
Expand All @@ -430,7 +444,11 @@
"Update capacity properties": {
"$ref": "./examples/FabricCapacities_Update.json"
}
}
},
"x-ms-long-running-operation-options": {
"final-state-via": "location"
},
"x-ms-long-running-operation": true
},
"delete": {
"operationId": "FabricCapacities_Delete",
Expand Down Expand Up @@ -460,8 +478,19 @@
}
],
"responses": {
"200": {
"description": "Resource deleted successfully."
"202": {
"description": "Resource deletion accepted.",
"headers": {
"Location": {
"type": "string",
"description": "The Location header contains the URL where the status of the long running operation can be checked."
},
"Retry-After": {
"type": "integer",
"format": "int32",
"description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
}
}
},
"204": {
"description": "Resource does not exist."
Expand All @@ -477,7 +506,11 @@
"Delete a capacity": {
"$ref": "./examples/FabricCapacities_Delete.json"
}
}
},
"x-ms-long-running-operation-options": {
"final-state-via": "location"
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Fabric/capacities/{capacityName}/resume": {
Expand Down