Skip to content

Conversation

@refortie
Copy link
Contributor

@refortie refortie commented Apr 27, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Apr 27, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2524

@AutorestCI
Copy link

AutorestCI commented Apr 27, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2830

@AutorestCI
Copy link

AutorestCI commented Apr 27, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#139

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️36 new Warnings.(65 total)
Code Id Source Message
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

AutorestCI commented Apr 27, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1776

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️36 new Warnings.(65 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@refortie
Copy link
Contributor Author

Wokring on fixing the model errors

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️36 new Warnings.(65 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️36 new Warnings.(65 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@annatisch annatisch removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 30, 2018
@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
2 new Errors.(3 total)
Code Id Source Message
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActionRepetitions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️39 new Warnings.(68 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionRoot' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'inputs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
2 new Errors.(3 total)
Code Id Source Message
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActionRepetitions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️39 new Warnings.(68 total)
Code Id Source Message
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionRoot' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'inputs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

],
"operationId": "IntegrationAccounts_GetCallbackUrl",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this operation used to be incorrectly named which you've fixed with the PR - is that correct?
Just so you're aware - this will be a breaking change - and therefore major version bump for the generated clients.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was the odd one out. I was really hoping that it wouldn't entail a breaking change. I'll revert it.

],
"operationId": "Agreements_CreateOrUpdate",
"description": "Creates or updates an integration account agreement.",
"operationId": "IntegrationAccountBatchConfigurations_CreateOrUpdate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Often a createOrUpdate that returns a 201, or a delete that returns a 204 - may be a indicative of a long running operation (x-ms-long-running-operation). I see none of the other create/delete functions use a long running API - but just to be sure, can you confirm that that's the case here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the objects are returned/deleted immediately (and not a reference to the object)

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
2 new Errors.(3 total)
Code Id Source Message
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActionRepetitions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️39 new Warnings.(69 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionRoot' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'inputs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@refortie
Copy link
Contributor Author

refortie commented May 1, 2018

@annatisch Do you have any more comments? The build failed, but I think that was for unrelated reasons

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
2 new Errors.(3 total)
Code Id Source Message
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.
CollectionObjectPropertiesNaming R3008 Link Collection object 'ExpressionTraces' returned by list operation 'WorkflowRunActionRepetitions_ListExpressionTraces' with 'x-ms-pageable' extension, has no property named 'value'.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️39 new Warnings.(69 total)
Code Id Source Message
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionRoot' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'inputs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@annatisch
Copy link
Member

@refortie - nope it looks good to me. Just waiting on last confirmation that those new linter errors you pointed out regarding the paging "value" attribute are a CI issue rather than a spec issue.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️0 new Warnings.(0 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️0 new Warnings.(0 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️39 new Warnings.(69 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionRoot' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'inputs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

"name": "agreement",
"description": "The integration account agreement.",
"name": "assemblyArtifact",
"description": "The assembly artifact.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the BatchConfiguration parameter being named and described as an AssemblyArtifact - is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was how it was written in the examples I was given, but it doesn't really make sense. I've changed it to be more in line with the function of the call

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️5 new Warnings.(119 total)
Code Id Source Message
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'repetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'scopeRepetitions' with immediate parent 'WorkflowRunAction', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'operations' with immediate parent 'WorkflowRun', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'assemblies' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
TrackedResourceListByImmediateParent R3010 Link The child tracked resource, 'batchConfigurations' with immediate parent 'IntegrationAccount', must have a list by immediate parent operation.
0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/logic/resource-manager/readme.md

⚠️39 new Warnings.(69 total)
Code Id Source Message
LongRunningOperationsWithLongRunningExtension R2007 Link The operation 'Workflows_Move' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation.
OperationIdNounVerb R1001 Link Per the Noun_Verb convention for Operation Ids, the noun 'Workflows' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
ParameterDescriptionRequired R4000 Link 'listContentCallbackUrl' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventsDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEvent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'TrackingEventErrorInfo' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'AccessKeyRegenerateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'SetTriggerStateActionDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionTraces' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'ExpressionRoot' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'Expression' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'sourceType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'trackEventsOptions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'events' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventLevel' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'eventTime' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'recordType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'message' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'code' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'keyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'source' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'inputs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'text' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'subexpressions' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'iterationCount' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
DescriptionAndTitleMissing R4000 Link 'content' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'metadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
AvoidNestedProperties R2001 Link Consider using x-ms-client-flatten to provide a better end user experience
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@annatisch annatisch merged commit b2da4e6 into Azure:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants