Skip to content

Conversation

@MikhailTryakhov
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov commented Apr 26, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@MikhailTryakhov
Copy link
Contributor Author

+@dsgouda to review May branch folder

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(95 total)
0 new Errors.(78 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(108 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

AutorestCI commented Apr 26, 2018

Automation for azure-libraries-for-java

A PR has been created for you:
AutorestCI/azure-libraries-for-java#117

@AutorestCI
Copy link

AutorestCI commented Apr 26, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2804

@AutorestCI
Copy link

AutorestCI commented Apr 27, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2493

@AutorestCI
Copy link

AutorestCI commented Apr 27, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1714

@EvgenyAgafonchikov
Copy link
Contributor

Actual version moved there: #2965

@lmazuel
Copy link
Member

lmazuel commented Apr 27, 2018

@EvgenyAgafonchikov are you saying this PR should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants