Skip to content

Adding Daemonset related flags to May 2024 GA #29579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FumingZhang merged 1 commit into from
Jun 26, 2024
Merged

Adding Daemonset related flags to May 2024 GA #29579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...ce/resource-manager/Microsoft.ContainerService/aks/stable/2024-05-01/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4598,6 +4598,21 @@
"title": "Detects similar node pools and balances the number of nodes between them.",
"description": "Valid values are 'true' and 'false'"
},
"daemonset-eviction-for-empty-nodes": {
"type": "boolean",
"title": "DaemonSet pods will be gracefully terminated from empty nodes",
"description": "If set to true, all daemonset pods on empty nodes will be evicted before deletion of the node. If the daemonset pod cannot be evicted another node will be chosen for scaling. If set to false, the node will be deleted without ensuring that daemonset pods are deleted or evicted."
Copy link
Member

@matthchr matthchr Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, can you fix the description here and in the latest preview API branch too to say what the default is?

Can add: "If not specified, the default is X" (true or false)

},
"daemonset-eviction-for-occupied-nodes": {
"type": "boolean",
"title": "DaemonSet pods will be gracefully terminated from non-empty nodes",
"description": "If set to true, all daemonset pods on occupied nodes will be evicted before deletion of the node. If the daemonset pod cannot be evicted another node will be chosen for scaling. If set to false, the node will be deleted without ensuring that daemonset pods are deleted or evicted."
},
"ignore-daemonsets-utilization": {
"type": "boolean",
"title": "Should CA ignore DaemonSet pods when calculating resource utilization for scaling down",
"description": "If set to true, the resources used by daemonset will be taken into account when making scaling down decisions."
},
"expander": {
"type": "string",
"enum": [
Expand Down