Update nodejs config for cognitive services#2948
Conversation
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-libraries-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
| nodejs: | ||
| package-name: azure-cognitiveservices-entitysearch | ||
| package-version: 1.0.0-preview | ||
| package-version: 1.1.0 |
There was a problem hiding this comment.
Note that the version we've actually published is 1.1.0--not likely to publish a new one as it looks like swagger has not changed. Just doing a correction here
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
| nodejs: | ||
| package-name: azure-cognitiveservices-imagesearch | ||
| package-version: 1.0.0-preview | ||
| package-version: 1.0.0 |
There was a problem hiding this comment.
Just curious, are these parts of Cognitive service live separately? So there is a package for VideoSearch and then another one for VisualSearch?
There was a problem hiding this comment.
Yeah, we publish a different npm package for each one.
|
Waiting for @daschult to take a look... |
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@daschult not much to see here but do you mind giving a review? |
|
@daschult already reviewed the corresponding PR on node SDK so I think this one is good to go. |
4 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger