Changes for Microsoft.DataMigration GA stable version 2018-04-19. by binuj · Pull Request #2936 · Azure/azure-rest-api-specs

binuj · 2018-04-24T01:25:49Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…review/2018-03-31-preview'. Next commit will have the actual changes for version 2018-04-19.

…s not scoped for GA.

AutorestCI · 2018-04-24T01:26:25Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-24T01:26:28Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

azuresdkciprbot · 2018-04-24T01:30:35Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(17 total)

❌0 new Errors.(6 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T01:30:35Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(29 total)

❌0 new Errors.(3 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-04-24T01:31:52Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2521

AutorestCI · 2018-04-24T01:49:31Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1768

azuresdkciprbot · 2018-04-24T03:00:55Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(17 total)

❌0 new Errors.(6 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T03:00:55Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(29 total)

❌0 new Errors.(3 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hitenjava · 2018-04-24T17:33:21Z

specification/datamigration/resource-manager/readme.md

 - Microsoft.DataMigration/preview/2018-03-31-preview/definitions/MigrationValidation.json
 - Microsoft.DataMigration/preview/2018-03-31-preview/definitions/ValidateMigrationInputSqlServerSqlMITask.json
 ```
+


Line 31 in readme.md has default as "tag: package-2018-03-31-preview".
Change this to the GA version. The public repo sdk picks up the version number from here.

Thanks, done.

azuresdkciprbot · 2018-04-24T17:55:05Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(21 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T17:55:05Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-04-24T18:07:42Z

specification/datamigration/resource-manager/readme.md

 - Microsoft.DataMigration/preview/2018-03-31-preview/definitions/ValidateMigrationInputSqlServerSqlMITask.json
 ```
+
+### Tag: package-2018-04-19


please reorganize readme.md to have most resent tag at the top.

hovsepm · 2018-04-24T18:10:06Z

...migration/resource-manager/Microsoft.DataMigration/stable/2018-04-19/definitions/Common.json

+          ],
+          "x-ms-enum": {
+            "name": "NameCheckFailureReason",
+            "modelAsString": true


"modelAsString": true [](start = 12, length = 21)

just a reminder - if enum is not modeled as string any time you will need to add a new enum member to it will be a breaking change and will require an API version bump. I'd strongly recommend marking enums as string

Just confirming - There is no change needed right? The usage here follows the recommended way of defining enums, correct?

Currently all the enums are marked as "modelAsString": true

No changes asked for now, just a warning for a possible breaking change in the future.

My comment rather came from already existing enums in Tasks.json (e.g. ProjectTaskProperties.State). Your PR has all the new enums marked as string types which is exactly what I was recommending :) sorry for the confusion.

hovsepm · 2018-04-24T18:11:31Z

...migration/resource-manager/Microsoft.DataMigration/stable/2018-04-19/definitions/Common.json

+          "description": "The current value of the quota. If null or missing, the current value cannot be determined in the context of the request."
+        },
+        "id": {
+          "type": "string",


Isn't this field read-only? if so should be marked as "readOnly": true,

In general any property of a type that is supposed to be sent only in one direction from Server to Client should be marked as "readOnly": true,

In reply to: 183830418 [](ancestors = 183830418)

hovsepm · 2018-04-24T18:19:36Z

@ravbhatnagar could you check if this was approved?

hovsepm · 2018-04-24T20:54:40Z

...tion/resource-manager/Microsoft.DataMigration/stable/2018-04-19/definitions/TasksCommon.json

+      "type": "object",
+      "description": "Information about a single database",
+      "properties": {
+        "id": {


id [](start = 9, length = 2)

Readonly?

hovsepm · 2018-04-24T20:54:59Z

...tion/resource-manager/Microsoft.DataMigration/stable/2018-04-19/definitions/TasksCommon.json

+          "type": "string",
+          "description": "Unique identifier for the database"
+        },
+        "name": {


name [](start = 9, length = 4)

Readonly?

Ordered readme.md contents from latest to oldest version. Marked response properties as readonly.

azuresdkciprbot · 2018-04-25T19:28:31Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T19:28:31Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(21 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-04-26T20:12:13Z

...manager/Microsoft.DataMigration/stable/2018-04-19/definitions/MigrateSqlServerSqlDbTask.json

+      "discriminator": "resultType"
+    },
+    "MigrateSqlServerSqlDbTaskOutputMigrationLevel": {
+      "x-ms-discriminator-value": "MigrationLevelOutput",


Please add "description" for this type

hovsepm · 2018-04-26T20:13:08Z

...tion/resource-manager/Microsoft.DataMigration/stable/2018-04-19/definitions/TasksCommon.json

+    "StartMigrationScenarioServerRoleResult": {
+      "type": "object",
+      "description": "",
+      "properties": {


Please add "description" for this type

hovsepm · 2018-04-26T20:21:59Z

...n/resource-manager/Microsoft.DataMigration/preview/2017-11-15-preview/definitions/Tasks.json

-          "type": "string"
+          "type": "string",
+          "readOnly": true
        },


if this type is marked as readonly it cannot be also marked as required. Required means that client has to send it to server each time, readonly means client only receives this type and cannot send it back to server. Please fix.

Removed readonly.

ravbhatnagar · 2018-04-26T22:30:52Z

The only big change from ARM standpoint is making some properties readonly. Since this change is made in a new api version, and the older version was preview, its fine. signing off!

azuresdkciprbot · 2018-04-27T00:49:09Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(15 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-27T00:49:09Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-04-27T18:22:56Z

@binuj could you fix Linter errors? - https://travis-ci.org/Azure/azure-rest-api-specs/jobs/371826015
Look for "type":"Error".

They have pretty good documentation. e.g.

{
  "type": "Error",
  "code": "DefinitionsPropertiesNamesCamelCase",
  "message": "Property named: 'Logins', for definition: 'ConnectToTargetSqlMITaskOutput' must follow camelCase style. Example: 'logins'.",
  "id": "R3016",
  "validationCategory": "RPCViolation",
  "providerNamespace": null,
  "resourceType": null,
  "sources": [
    "file:///home/travis/build/Azure/azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2018-03-31-preview/definitions/ConnectToTargetSqlMITask.json:52:8 ($.definitions.ConnectToTargetSqlMITaskOutput.properties.Logins)"
  ],
  "jsonref": "file:///home/travis/build/Azure/azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2018-03-31-preview/definitions/ConnectToTargetSqlMITask.json:52:8 ($.definitions.ConnectToTargetSqlMITaskOutput.properties.Logins)",
  "json-path": "file:///home/travis/build/Azure/azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2018-03-31-preview/definitions/ConnectToTargetSqlMITask.json:52:8 ($.definitions.ConnectToTargetSqlMITaskOutput.properties.Logins)"
}

azuresdkciprbot · 2018-04-27T22:12:48Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(15 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-27T22:12:48Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-27T23:01:31Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-27T23:01:31Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(15 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-04-28T04:42:05Z

one left

Executing: npx autorest@2.0.4152 --validation --azure-validator --message-format=json specification/datamigration/resource-manager/readme.md --tag=package-2017-11-15-preview
{
  "type": "Error",
  "code": "RequiredReadOnlyProperties",
  "message": "Property 'taskType' is a required property. It should not be marked as 'readonly'.",
  "id": "R2056",
  "validationCategory": "SDKViolation",
  "providerNamespace": null,
  "resourceType": null,
  "sources": [
    "file:///home/travis/build/Azure/azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2017-11-15-preview/definitions/Tasks.json:25:8 ($.definitions.ProjectTaskProperties.properties.taskType)"
  ],
  "jsonref": "file:///home/travis/build/Azure/azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2017-11-15-preview/definitions/Tasks.json:25:8 ($.definitions.ProjectTaskProperties.properties.taskType)",
  "json-path": "file:///home/travis/build/Azure/azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2017-11-15-preview/definitions/Tasks.json:25:8 ($.definitions.ProjectTaskProperties.properties.taskType)"
}

hovsepm · 2018-04-28T04:45:08Z

There are also bunch of missing documentation fields. They will be used in all the auto-generated languages as hints for developers so it is highly suggested to have human readable documentation text. You can see all the doc issues in this build https://travis-ci.org/Azure/azure-rest-api-specs/jobs/372255731. They start with

{
  "type": "Warning",
  "code": "DescriptionAndTitleMissing",

azuresdkciprbot · 2018-04-30T19:38:25Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(11 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T19:38:25Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-04-30T23:32:38Z

@binuj please revert changes to the specs of the previous versions - no need to fix those issues in this PR.

…only focused on stable 2018-04-19. Marked some properties as readonly in '2018-04-19\definitions\TasksCommon.json'

azuresdkciprbot · 2018-05-02T05:53:07Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(11 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-02T05:53:07Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/datamigration/resource-manager/readme.md

⚠️

0 new Warnings.(16 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

hovsepm · 2018-05-02T21:39:06Z

@binuj please fix Linter errors like "Property named: 'Logins', for definition: 'ConnectToTargetSqlMITaskOutput' must follow camelCase style. Example: 'logins'.", here https://travis-ci.org/Azure/azure-rest-api-specs/jobs/373778210

hovsepm · 2018-05-02T21:44:35Z

ignore my last comment - errors are in previous preview specs and were marked by Linter due to description change in your current pr.

binuj added 2 commits April 23, 2018 09:53

Initial commit for GA stable version 2018-04-19. Files copied from 'p…

0975cfa

…review/2018-03-31-preview'. Next commit will have the actual changes for version 2018-04-19.

Changes for GA stable version 2018-04-19. Removed MI sceanrio as it i…

2c66e1f

…s not scoped for GA.

binuj requested a review from hitenjava April 24, 2018 01:25

azuresdkci assigned hovsepm Apr 24, 2018

azuresdkci requested a review from hovsepm April 24, 2018 01:26

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR datamigration/resource-manager] Changes for Microsoft.DataMigration GA stable version 2018-04-19. Azure/azure-sdk-for-go#1688

Closed

Part of GA stable version 2018-04-19 : Fixed autorest validation errors.

f268a8e

hitenjava reviewed Apr 24, 2018

View reviewed changes

Changed default package to 2018-04-19 in readme.md.

a8c64b9

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR datamigration/resource-manager] Changes for Microsoft.DataMigration GA stable version 2018-04-19. Azure/azure-sdk-for-python#2459

Merged

hovsepm reviewed Apr 24, 2018

View reviewed changes

hovsepm added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2018

hovsepm reviewed Apr 24, 2018

View reviewed changes

Addressed comments.

16e27cc

Ordered readme.md contents from latest to oldest version. Marked response properties as readonly.

hovsepm reviewed Apr 26, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 26, 2018

Addressed comments. Added description for some types.

aecfb57

Fixed Linter errors for files in version '2018-03-31-preview'.

743b522

Fixed Linter error.

6fa2852

Addressed comnments. Added missing documentation.

cd9c374

Revert all breaking changes in preview version folders as this PR is …

76e9462

…only focused on stable 2018-04-19. Marked some properties as readonly in '2018-04-19\definitions\TasksCommon.json'

AutorestCI mentioned this pull request May 2, 2018

[AutoPR datamigration/resource-manager] Changes for Microsoft.DataMigration GA stable version 2018-04-19. Azure/azure-sdk-for-go#1762

Merged

hovsepm approved these changes May 2, 2018

View reviewed changes

hovsepm merged commit deee6ca into Azure:master May 2, 2018

Conversation

binuj commented Apr 24, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hovsepm commented Apr 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

binuj commented Apr 24, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

hovsepm Apr 26, 2018 •

edited

Loading