-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Added information to the Weather services query uri parameter #29356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generally available for locations on land, bodies of water surrounded by land, and areas of the ocean that are within approximately 50 nautical miles of a coastline.'
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| weather.json | 1.1(a35c5c5) | 1.1(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| 1.1 | 1.1(a35c5c5) | 1.1(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L286 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L332 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L381 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L436 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L485 |
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Weather' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Weather/stable/1.1/weather.json#L512 |
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Weather' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Weather/stable/1.1/weather.json#L556 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L624 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L630 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Weather/stable/1.1/weather.json#L636 |
| API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'. Location: Weather/stable/1.1/weather.json#L5 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Weather/stable/1.1/weather.json#L53 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Weather/stable/1.1/weather.json#L224 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Weather/stable/1.1/weather.json#L233 |
|
| Based on the response model schema, operation 'Weather_GetHourlyForecast' might be pageable. Consider adding the x-ms-pageable extension. Location: Weather/stable/1.1/weather.json#L261 |
|
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Weather/stable/1.1/weather.json#L261 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Weather/stable/1.1/weather.json#L277 |
|
The error property in the error response schema should be required.Location: Weather/stable/1.1/weather.json#L303 |
|
Error schema should define code and message properties as required.Location: Weather/stable/1.1/weather.json#L303 |
|
| Error response should contain a x-ms-error-code header. Location: Weather/stable/1.1/weather.json#L303 |
|
| Based on the response model schema, operation 'Weather_GetMinuteForecast' might be pageable. Consider adding the x-ms-pageable extension. Location: Weather/stable/1.1/weather.json#L310 |
|
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Weather/stable/1.1/weather.json#L310 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Weather/stable/1.1/weather.json#L326 |
|
The error property in the error response schema should be required.Location: Weather/stable/1.1/weather.json#L349 |
|
Error schema should define code and message properties as required.Location: Weather/stable/1.1/weather.json#L349 |
|
| Error response should contain a x-ms-error-code header. Location: Weather/stable/1.1/weather.json#L349 |
|
| Based on the response model schema, operation 'Weather_GetQuarterDayForecast' might be pageable. Consider adding the x-ms-pageable extension. Location: Weather/stable/1.1/weather.json#L356 |
|
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Weather/stable/1.1/weather.json#L356 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Weather/stable/1.1/weather.json#L372 |
|
The error property in the error response schema should be required.Location: Weather/stable/1.1/weather.json#L398 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
jhendrixMSFT
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC UPDATE: Added information to the query uri parameter: 'Weather information is generally available for locations on land, bodies of water surrounded by land, and areas of the ocean that are within approximately 50 nautical miles of a coastline.'