AzureStack Network Admin - Removed extraneous properties on Quota

[deathly809]

There was a bug in which QuotaProperties was given two extra properties from a referenced definition. I have split the referenced object into two new definitions, one which has a provisioning state (ProvisionedResource) and another which contains tenant related properties (TenantResource). QuotaProperties now only correctly referenced ProvisionedResource. I have also updated all resources to include the two new references.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

[AutorestCI]

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

[AutorestCI]

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

[azuresdkciprbot]

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/azsadmin/resource-manager/network/readme.md

⚠️0 new Warnings.(0 total)

❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/azsadmin/resource-manager/network/readme.md

⚠️0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[marstr]

Givent that you're in preview, changing names, etc, is permissable.

I do want to call out here though, you're missing an important ARM operation: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/370282355#L746

Before your swagger is moved into the stable folder, you're going to have to add an "operations" path. Additionaly, you're going to need a README with tags that allow code generation into the various AutoRest supported languages. You'll see by the empty comments above that our automation is not engaged without that README.

[deathly809]

@marstr Yeah I know. I told the NRP team about it and they are working on it. I actually wrote most of the code and handed it over to them but it seems they didn't finish it.

We currently do not support any language other than C# and will not add extra languages at this time.

[deathly809]

@dsgouda They added the WaitForArmFeedback. What can I do to get this expedited?

[dsgouda]

@deathly809 you will have to go through the process, maybe you can ping on the slack channel for swagger reviewers but I wouldn't be able to expedite it

[ravbhatnagar]

This does not need to be reviewed by ARM team since this is Azure Stack

[deathly809]

@marstr can you please merge so I can begin the SDK PR? Thanks!