Modify Workbook Resource Type to include RG and remove unused endpoint by ericc1103 · Pull Request #2898 · Azure/azure-rest-api-specs

ericc1103 · 2018-04-18T18:02:55Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…specs

This reverts commit bed6bc3.

This reverts commit c245a85.

… we are not using sourceId anymore

… remove unused endpoint

AutorestCI · 2018-04-18T18:04:32Z

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpspi6zdvl/rest/specification/applicationinsights/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpspi6zdvl/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/applicationinsights/implementation/FavoritesInner.java
   at AutoRest.Core.CodeGenerator.<Write>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.<Generate>d__6.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISHedxhk\164_20180307T193002\autorest.java\src\azurefluent\CodeGeneratorJvaf.cs:line 57
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISHedxhk\164_20180307T193002\autorest.java\src\Program.cs:line 115
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Process() cancelled due to exception : Plugin java reported failure.
  Error: Plugin java reported failure.

AutorestCI · 2018-04-18T18:04:34Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2691

AutorestCI · 2018-04-18T18:04:57Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2022

AutorestCI · 2018-04-18T18:06:41Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1665

azuresdkciprbot · 2018-04-18T18:07:36Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/applicationinsights/resource-manager/readme.md
Before the PR: Warning(s): 7 Error(s): 0
After the PR: Warning(s): 6 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

marstr · 2018-04-19T16:57:07Z

Load balancing my review load out to the very capable, @jianghaolu.

jianghaolu · 2018-04-19T19:44:04Z

...applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/workbooks_API.json

-        }
-      }
-    },
-    "/subscriptions/{subscriptionId}/providers/microsoft.insights/workbooks": {  


It's a breaking change to remove an operation here. No breaking changes should be made to an existing stable Swagger.

@jianghaolu Thanks for reviewing this. This is new resource type that we just got approved last week. This is not deployed to PROD yet. This is the endpoint we overlooked and needed to be removed.

@ericc1103 Sounds good. When are you deploying to PROD?

I am currently working with ARM team and ETA is tomorrow.

@ericc1103 Please add "merge on [date]" on the PR title once you have an ETA. I've approved for now and on the deployment date we can merge.

@jianghaolu It is now merged in PROD ARM. You can go ahead and approve to merge.

Merging now.

jianghaolu · 2018-04-19T20:07:23Z

Breaking change but the endpoint hasn't been deployed yet so we will take it. Still waiting for the endpoints to be deployed to merge.

ericc1103 added 15 commits March 29, 2018 14:18

Adding Workbooks resource type.

a892e9f

Rename workbookDelete.json to WorkbookDelete.json

aee9914

Fixed undefiend parameter issue with Delete verb.

4ba66aa

Merge branch 'master' of https://github.com/ericc1103/azure-rest-api-…

e6041b2

…specs

Update swagger to add subscriptionId

6672215

Fixed duplicated operation id issue

92ff8e9

Removed links endpoint

c245a85

Removed unused samples

bed6bc3

Revert "Removed unused samples"

d3bac20

This reverts commit bed6bc3.

Revert "Removed links endpoint"

5259a41

This reverts commit c245a85.

Removed link logic and added get by resourceid

4227f6c

Applied PR comments

328b75c

Added Resource Group parameter for GET. Removed get by sourceId since…

b742198

… we are not using sourceId anymore

Merged with upstream. Modify Workbook Resource Type to include RG and…

15a0dcb

… remove unused endpoint

Resolved the merge conflicts with readme.md

12a3962

azuresdkci assigned marstr Apr 18, 2018

azuresdkci requested a review from marstr April 18, 2018 18:03

AutorestCI mentioned this pull request Apr 18, 2018

[AutoPR applicationinsights/resource-manager] Modify Workbook Resource Type to include RG and remove unused endpoint Azure/azure-sdk-for-node#2756

Merged

AutorestCI mentioned this pull request Apr 18, 2018

[AutoPR applicationinsights/resource-manager] Modify Workbook Resource Type to include RG and remove unused endpoint Azure/azure-sdk-for-python#2425

Merged

AutorestCI mentioned this pull request Apr 18, 2018

[AutoPR applicationinsights/resource-manager] Modify Workbook Resource Type to include RG and remove unused endpoint Azure/azure-sdk-for-go#1643

Merged

marstr assigned jianghaolu and unassigned marstr Apr 19, 2018

jianghaolu reviewed Apr 19, 2018

View reviewed changes

jianghaolu approved these changes Apr 19, 2018

View reviewed changes

jianghaolu merged commit dfaf222 into Azure:master Apr 20, 2018

Conversation

ericc1103 commented Apr 18, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Apr 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Apr 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Apr 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Apr 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkciprbot commented Apr 18, 2018

Uh oh!

marstr commented Apr 19, 2018

Uh oh!

jianghaolu Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

ericc1103 Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

ericc1103 Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

ericc1103 Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Apr 20, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu commented Apr 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ericc1103 commented Apr 18, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 18, 2018 •

edited

Loading

AutorestCI commented Apr 18, 2018 •

edited

Loading

AutorestCI commented Apr 18, 2018 •

edited

Loading

AutorestCI commented Apr 18, 2018 •

edited

Loading