Update summary desc geolocation#28489
Merged
jhendrixMSFT merged 3 commits intoAzure:mainfrom Mar 27, 2024
Merged
Conversation
stevemunk
requested review from
johanste and
vicancy
and removed request for
a team
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they will.Addressing the following failures is highly recommended:
|
Swagger Validation Report
|
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| geolocation.json | 1.0(3e40486) | 1.0(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| 1.0-preview | 1.0-preview(3e40486) | 1.0-preview(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'. Location: Geolocation/preview/1.0/geolocation.json#L5 |
|
| A required parameter should not specify a default value. Location: Geolocation/preview/1.0/geolocation.json#L80 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Geolocation/preview/1.0/geolocation.json#L83 |
|
| Error response should contain a x-ms-error-code header. Location: Geolocation/preview/1.0/geolocation.json#L102 |
|
The error property in the error response schema should be required.Location: Geolocation/preview/1.0/geolocation.json#L102 |
|
Error schema should define code and message properties as required.Location: Geolocation/preview/1.0/geolocation.json#L102 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
jhendrixMSFT
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.