Custom node image upgrade type in UpdateRun#28470
Merged
serbrech merged 2 commits intoAzure:dev-aks-fleet-2024-05-02-previewfrom Apr 9, 2024
Merged
Custom node image upgrade type in UpdateRun#28470serbrech merged 2 commits intoAzure:dev-aks-fleet-2024-05-02-previewfrom
serbrech merged 2 commits intoAzure:dev-aks-fleet-2024-05-02-previewfrom
Conversation
minhng22
requested review from
alvinli222,
circy9,
matthchr,
palma21 and
weinong
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| fleets.json | 2024-05-02-preview(0f5f773) | 2023-10-15(main) |
| fleets.json | 2024-05-02-preview(0f5f773) | 2024-02-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The read only property has changed from 'true' to 'false'. New: fleet/preview/2024-05-02-preview/fleets.json#L1923:9 Old: fleet/stable/2023-10-15/fleets.json#L1747:9 |
|
The read only property has changed from 'true' to 'false'. New: fleet/preview/2024-05-02-preview/fleets.json#L1969:9 Old: fleet/stable/2023-10-15/fleets.json#L1794:9 |
|
The read only property has changed from 'true' to 'false'. New: fleet/preview/2024-05-02-preview/fleets.json#L2619:9 Old: fleet/stable/2023-10-15/fleets.json#L2340:9 |
|
The read only property has changed from 'true' to 'false'. New: fleet/preview/2024-05-02-preview/fleets.json#L2197:9 Old: fleet/stable/2023-10-15/fleets.json#L2019:9 |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| default | default(0f5f773) | default(dev-aks-fleet-2024-05-02-preview) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️❌TypeSpecAPIView: 0 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
| "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 26, 2024
This was referenced Mar 26, 2024
serbrech
reviewed
Mar 26, 2024
serbrech
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.