Update Compute Diagnostic RP swagger doc API version to 2021-06-01-preview by Elina-L · Pull Request #28354 · Azure/azure-rest-api-specs

Elina-L · 2024-03-20T20:23:07Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- This PR is to update existing Compute Diagnostic RP APIs to point to an older API version 2021-06-01-preview. There are no code differences between the two API versions, and all affected APIs function completely the same between the two API versions.
  The reason for this "downgrade" is because the new API version ARM manifest is still being rolled out by CRP team, but is taking longer than expected due to unforseen blockers, and this delayed rollout is blocking our targeted release for Az PS and CLI related PRs. https://msazure.visualstudio.com/One/_release?definitionId=18535&view=mine&_a=releases
  Once the Compute Manifest has completed the rollout, we will "upgrade" the API version back to the latest API version.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-03-20T20:23:12Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
❌ The required check named TypeSpec Requirement (resource-manager) has failed. TypeSpec usage is required for all new (aka "greenfield") services. The automation detected this pull request adds at least one new service that is violating this requirement. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp.

openapi-pipeline-app · 2024-03-20T20:23:12Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared specs (v0.10.5)	new version	base version
diagnostic.json	2024-03-01-preview(f3691ca)	2024-03-01-preview(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 1 Warnings warning [Detail]

Compared specs (v2.2.0)	new version	base version
package-2024-03-01-preview-only	package-2024-03-01-preview-only(f3691ca)	package-2024-03-01-preview-only(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ PreviewVersionOverOneYear	The API version:2021-06-01-preview having been in a preview state over one year , please move it to GA or retire. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L6

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ GetInOperationName	'GET' operation 'DiagnosticOperations_Read' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L42
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'run' in:'DiskInspection_Create'. Consider updating the operationId Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L92
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets the status of a scheduled disk inspection request. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L180
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Gets the status of a scheduled disk inspection request. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L219
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'registerstorageconfiguration' in:'DiskInspectionStorageConfiguration_Register'. Consider updating the operationId Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L231
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'validatestorageconfiguration' in:'DiskInspectionStorageConfiguration_Validate'. Consider updating the operationId Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L280
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'generate' in:'SpotPlacementRecommender_Post'. Consider updating the operationId Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L362
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L557
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L595
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L607
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L624
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L636
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L640
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L679

️❌Avocado: 1 Errors, 1 Warnings failed [Detail]

Rule	Message
`❌` INCONSISTENT_API_VERSION	The API version of the swagger is inconsistent with its file path. readme: specification/compute/resource-manager/readme.md json: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` INVALID_REQUEST_PARAMETER	api-version 2024-03-01-preview is not equal to swagger version Url: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L38:14 ExampleUrl: preview/2024-03-01-preview/examples/GetDiagnosticOperation.json#L2:17
`❌` OBJECT_MISSING_REQUIRED_PROPERTY	Missing required property: api-version Url: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L640:28 ExampleUrl: preview/2024-03-01-preview/examples/GetDiagnosticOperation.json#L6:20
`❌` INVALID_REQUEST_PARAMETER	api-version 2024-03-01-preview is not equal to swagger version Url: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L88:15 ExampleUrl: preview/2024-03-01-preview/examples/RunDiskInspection.json#L2:17
`❌` INVALID_REQUEST_PARAMETER	api-version 2024-03-01-preview is not equal to swagger version Url: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L227:15 ExampleUrl: preview/2024-03-01-preview/examples/RegisterStorageConfiguration.json#L2:17
`❌` INVALID_REQUEST_PARAMETER	api-version 2024-03-01-preview is not equal to swagger version Url: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L276:15 ExampleUrl: preview/2024-03-01-preview/examples/ValidateStorageConfiguration.json#L2:17
`❌` INVALID_REQUEST_PARAMETER	api-version 2024-03-01-preview is not equal to swagger version Url: DiagnosticRP/preview/2024-03-01-preview/diagnostic.json#L358:15 ExampleUrl: preview/2024-03-01-preview/examples/SpotPlacementRecommender.json#L2:17

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-20T20:23:13Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m

❌Azure.ResourceManager.Compute [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh]      Speed
cmderr	[init.sh] k
cmderr	[init.sh]  notice
cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[init.sh] npm notice
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] ##################### 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]

azure-arm-compute-21.6.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface EventGridAndResourceGraph
info	[Changelog]   - Added Interface ScheduledEventsAdditionalPublishingTargets
info	[Changelog]   - Added Interface ScheduledEventsPolicy
info	[Changelog]   - Added Interface UserInitiatedReboot
info	[Changelog]   - Added Interface UserInitiatedRedeploy
info	[Changelog]   - Added Type Alias ResourceIdOptionsForGetCapacityReservationGroups
info	[Changelog]   - Interface CapacityReservationGroupsListBySubscriptionOptionalParams has a new optional parameter resourceIdsOnly
info	[Changelog]   - Interface DataDisk has a new optional parameter sourceResource
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter caching
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter deleteOption
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter diskEncryptionSet
info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter writeAcceleratorEnabled
info	[Changelog]   - Interface VirtualMachine has a new optional parameter scheduledEventsPolicy
info	[Changelog]   - Interface VirtualMachineScaleSet has a new optional parameter scheduledEventsPolicy
info	[Changelog]   - Interface VirtualMachineScaleSetUpdateOSDisk has a new optional parameter diffDiskSettings
info	[Changelog]   - Interface VirtualMachineScaleSetVMReimageParameters has a new optional parameter forceUpdateOSDiskForEphemeral
info	[Changelog]   - Interface VirtualMachineUpdate has a new optional parameter scheduledEventsPolicy
info	[Changelog]   - Added Enum KnownResourceIdOptionsForGetCapacityReservationGroups
info	[Changelog]   - Enum KnownDiffDiskPlacement has a new value NvmeDisk
info	[Changelog]   - Enum KnownDiskCreateOptionTypes has a new value Copy
info	[Changelog]   - Enum KnownDiskCreateOptionTypes has a new value Restore

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `DiffDiskPlacementNvmeDisk` added to enum type `DiffDiskPlacement`
info	[Changelog] - New value `DiskCreateOptionTypesCopy`, `DiskCreateOptionTypesRestore` added to enum type `DiskCreateOptionTypes`
info	[Changelog] - New enum type `ResourceIDOptionsForGetCapacityReservationGroups` with values `ResourceIDOptionsForGetCapacityReservationGroupsAll`, `ResourceIDOptionsForGetCapacityReservationGroupsCreatedInSubscription`, `ResourceIDOptionsForGetCapacityReservationGroupsSharedWithSubscription`
info	[Changelog] - New struct `EventGridAndResourceGraph`
info	[Changelog] - New struct `ScheduledEventsAdditionalPublishingTargets`
info	[Changelog] - New struct `ScheduledEventsPolicy`
info	[Changelog] - New struct `UserInitiatedReboot`
info	[Changelog] - New struct `UserInitiatedRedeploy`
info	[Changelog] - New field `ResourceIDsOnly` in struct `CapacityReservationGroupsClientListBySubscriptionOptions`
info	[Changelog] - New field `SourceResource` in struct `DataDisk`
info	[Changelog] - New field `Caching`, `DeleteOption`, `DiskEncryptionSet`, `WriteAcceleratorEnabled` in struct `DataDisksToAttach`
info	[Changelog] - New field `ScheduledEventsPolicy` in struct `VirtualMachineProperties`
info	[Changelog] - New field `ScheduledEventsPolicy` in struct `VirtualMachineScaleSetProperties`
info	[Changelog] - New field `ForceUpdateOSDiskForEphemeral` in struct `VirtualMachineScaleSetReimageParameters`
info	[Changelog] - New field `DiffDiskSettings` in struct `VirtualMachineScaleSetUpdateOSDisk`
info	[Changelog] - New field `ForceUpdateOSDiskForEphemeral` in struct `VirtualMachineScaleSetVMReimageParameters`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 25 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from a8d49f08d743c942687552635a1092217a2460a0. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.compute.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-20T20:23:14Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	https://apiview.dev/Assemblies/Review/08ab188fdab64564bc46944e13addcf9?revisionId=ff8d37bb23d94544a3151776c938b5e9
JavaScript	@azure/arm-compute	https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=a65264023ef743e8916d03001289a697
Java	azure-resourcemanager-compute-generated	https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=10e332408b3d4d11bbbca3a9aa583107
Swagger	Microsoft.Compute	https://apiview.dev/Assemblies/Review/b32a43d6ad48477b9343d7a921e72411?revisionId=21581ff7e83e4c1a87e4c5a9b9f1e3b3

…21-06-01-preview

Elina-L · 2024-03-20T23:18:31Z

The PR is failing LintDiff and model validation checks because the API-version does not match the package version, should I request a temporary suppression for this PR?

ms-zhenhua · 2024-03-21T08:36:31Z

...e/resource-manager/Microsoft.Compute/DiagnosticRP/preview/2024-03-01-preview/diagnostic.json

    "title": "ComputeDiagnosticResourceProviderClient",
    "description": "The Compute Diagnostic Resource Provider Client",
-    "version": "2024-03-01-preview"
+    "version": "2021-06-01-preview"


why change to 2021?

Hi Zhenhua, this is because the new 2024-03-01-preview version is blocked by the ARM compute manifest rollout taking very long to deploy. https://msazure.visualstudio.com/One/_release?definitionId=18535&view=mine&_a=releases

Without the ARM manifest rolled out, the APIs in this swagger are unable to invoke using 2024-03-01-preview API version. This is blocking our Az PS PR from merging in by the current release milestone cutoff 3/25.

In order to unblock the PS PR, we decided to "downgrade" the API version from 2024-03-01-preview to 2021-06-01-preview. There are no code differences between the two API versions in our service and all APIs on this swagger doc function exactly the same between the two versions. We are downgrading to get the PS cmdlet unblocked, once the ARM manifest is merged, we will upgrade the version back to 2024-03-01-preview. Since there are no changes between the two versions, "upgrading" it back to the latest is only to align with ARM swagger doc conventions and not for any feature/functionality change.

If possible, please let us know if we can merge this ASAP to unblock the Az PS PR. Thank you

AzPS PR: Azure/azure-powershell#24352

AFAIK, it's not allowed. The API version in the file should be consistent with the name of the folder which includes the file, and the content in the readme. Since 2021-06-01-preview already exists, it will cause two files point to the same API version. And since you do not update the readme, the related SDK may not be generated.

openapi-workflow-bot · 2024-03-21T08:36:49Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

…21-06-01-preview

microsoft-github-policy-service · 2024-04-29T00:02:31Z

Hi, @Elina-L. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

microsoft-github-policy-service · 2024-05-13T13:04:04Z

Hi, @Elina-L. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

Initial change - update diagnostic.json version to 2021-06-01-preview

ce6527b

Elina-L requested review from MS-syh2qs, Sandido, dkulkarni-ms, grizzlytheodore and haagha as code owners March 20, 2024 20:23

azure-sdk mentioned this pull request Mar 20, 2024

[AutoPR sdk/resourcemanager/compute/armcompute] Update Compute Diagnostic RP swagger doc API version to 2021-06-01-preview azure-sdk/azure-sdk-for-go#9392

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 20, 2024

Elina-L added 2 commits March 20, 2024 15:54

Merge branch 'main' into wenxliu/SpotPlacementRecommenderAPIVersion20…

7e277ba

…21-06-01-preview

Merge branch 'main' into wenxliu/SpotPlacementRecommenderAPIVersion20…

a0e92a4

…21-06-01-preview

ms-zhenhua reviewed Mar 21, 2024

View reviewed changes

ms-zhenhua added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 21, 2024

ansahdev removed the ARMChangesRequested label Mar 21, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 21, 2024

Merge branch 'main' into wenxliu/SpotPlacementRecommenderAPIVersion20…

f3691ca

…21-06-01-preview

ms-zhenhua removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 22, 2024

ms-zhenhua added the ARMChangesRequested label Mar 22, 2024

microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Apr 8, 2024

microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Apr 29, 2024

microsoft-github-policy-service bot closed this May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Compute Diagnostic RP swagger doc API version to 2021-06-01-preview#28354

Update Compute Diagnostic RP swagger doc API version to 2021-06-01-preview#28354
Elina-L wants to merge 4 commits intoAzure:mainfrom
Elina-L:wenxliu/SpotPlacementRecommenderAPIVersion2021-06-01-preview

Elina-L commented Mar 20, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

Uh oh!

Elina-L commented Mar 20, 2024

Uh oh!

ms-zhenhua Mar 21, 2024

Uh oh!

Elina-L Mar 21, 2024 •

edited

Loading

Uh oh!

ms-zhenhua Mar 22, 2024

Uh oh!

openapi-workflow-bot bot commented Mar 21, 2024

Uh oh!

microsoft-github-policy-service bot commented Apr 29, 2024

Uh oh!

microsoft-github-policy-service bot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Elina-L commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Elina-L commented Mar 20, 2024

Uh oh!

ms-zhenhua Mar 21, 2024

Choose a reason for hiding this comment

Uh oh!

Elina-L Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ms-zhenhua Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

openapi-workflow-bot bot commented Mar 21, 2024

Uh oh!

microsoft-github-policy-service bot commented Apr 29, 2024

Uh oh!

microsoft-github-policy-service bot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Elina-L commented Mar 20, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 20, 2024 •

edited

Loading

Elina-L Mar 21, 2024 •

edited

Loading