Skip to content

Azure Search: Removing indexer related limits from service statistics API#2824

Merged
anuchandy merged 2 commits intoAzure:masterfrom
natinimni:azure-search-service-stats-api-remove-indexer-limits
Apr 6, 2018
Merged

Azure Search: Removing indexer related limits from service statistics API#2824
anuchandy merged 2 commits intoAzure:masterfrom
natinimni:azure-search-service-stats-api-remove-indexer-limits

Conversation

@natinimni
Copy link
Copy Markdown
Contributor

@natinimni natinimni commented Apr 5, 2018

… API

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@natinimni
Copy link
Copy Markdown
Contributor Author

FYI, @brjohnstmsft

@brjohnstmsft
Copy link
Copy Markdown
Member

@anuchandy Some context for this change -- We recently discovered that these properties we were about to add are actually deprecated and will be removed (no customers are using them), hence we need to remove them from the Swagger before we can ship the next version of our data plane SDK.

@brjohnstmsft
Copy link
Copy Markdown
Member

@natinimni Are those properties in the example as well? If so, they should be removed there too.

Copy link
Copy Markdown
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service is in preview hence these breaking changes are fine.

@anuchandy
Copy link
Copy Markdown
Member

thanks @natinimni, @brjohnstmsft. Looks good, merging.

@anuchandy anuchandy merged commit f1830cd into Azure:master Apr 6, 2018
@natinimni natinimni deleted the azure-search-service-stats-api-remove-indexer-limits branch April 6, 2018 17:06
@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/search/data-plane/Microsoft.Azure.Search.Service/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants