EventHub: removed messaging plan from namespace#2807
Merged
lmazuel merged 1 commit intoAzure:masterfrom Apr 4, 2018
Merged
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Member
|
@lmazuel assigned myself as one of the reviewer. I had an email conversation with @v-Ajnava and @arundsouza . Exposing this endpoint was an error in the swagger, the MessagingPlan data is already available in namespace resource. Service team will not expose this api in future api versions as well. |
anuchandy
approved these changes
Apr 4, 2018
lmazuel
approved these changes
Apr 4, 2018
Member
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
Anu says it's fine, then it's fine ;)
Member
|
@lmazuel thanks! |
v-Ajnava
pushed a commit
to v-Ajnava/azure-rest-api-specs
that referenced
this pull request
Apr 10, 2018
This reverts commit b5e8859.
hovsepm
pushed a commit
that referenced
this pull request
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger